Rework selenium tests from organizations package #7389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 3, 2017 18:13
…ganizationTests
…ganizationTests
…ganizationTests
SkorikSergey
added
kind/task
dmytro-ndp
reviewed
Nov 15, 2017
| * | ||
| * @author Ann Shumilova | ||
| */ | ||
| public class DeleteOrganizationTest { | ||
| private static final String PARENT_ORG_NAME = generate("organization", 5); |
There was a problem hiding this comment.
Let's add "parent-" prefix to the name to simplify test result review.
dmytro-ndp
reviewed
Nov 15, 2017
| * | ||
| * @author Ann Shumilova | ||
| */ | ||
| public class DeleteOrganizationTest { | ||
| private static final String PARENT_ORG_NAME = generate("organization", 5); | ||
| private static final String CHILD_ORG_NAME = generate("organization", 5); |
There was a problem hiding this comment.
Let's add "child-" prefix to the name to simplify test result review.
dmytro-ndp
reviewed
Nov 15, 2017
| testOrganizationServiceClient.deleteById(childOrganization.getId()); | ||
| testOrganizationServiceClient.deleteById(parentOrganization.getId()); | ||
| for (OrganizationDto organization : organizations) | ||
| testOrganizationServiceClient.deleteById(organization.getId()); |
There was a problem hiding this comment.
Such code can affect organizations which are created in parallel threads of test execution.
There was a problem hiding this comment.
The Organizations list includes only organizations from this test.
There was a problem hiding this comment.
I see.
organizations field is used for tearDown() method only.
To simplify the code, we could avoid usage of organizations field at all and to remove two organizations explicitly instead:
testOrganizationServiceClient.deleteById(childOrganization.getId());
testOrganizationServiceClient.deleteById(parentOrganization.getId());
dmytro-ndp
reviewed
Nov 15, 2017
| public void testSubOrganizationRename() { | ||
| String organizationPath = NEW_PARENT_ORG_NAME + "/" + CHILD_ORG_NAME; | ||
| String path = NEW_PARENT_ORG_NAME + "/" + NEW_CHILD_ORG_NAME; |
There was a problem hiding this comment.
dmytro-ndp
reviewed
Nov 15, 2017
| assertFalse(organizationPage.isWorkspaceCapReadonly()); | ||
| assertFalse(organizationPage.isRunningCapReadonly()); | ||
| assertFalse(organizationPage.isRAMCapReadonly()); | ||
| assertFalse(organizationPage.isWorkspaceCapReadonly()); |
|
It seems the most notices from previous pull request were fixed in the request. |
dmytro-ndp
approved these changes
Nov 15, 2017
tolusha
approved these changes
Nov 16, 2017
benoitf
removed
the
status/code-review
dmytro-ndp
pushed a commit
that referenced
this pull request
Dec 8, 2017
* reworked deleting organizations in AfterClass, deleted unused user, deleted test methods with similar use cases, created selenium test for checking organization creation. * selenium tests reworked for starting in test suites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need rework selenium tests from organizations package:
What issues does this PR fix or reference?
#7121