Fix samples.json loading #7452
Merged
Fix samples.json loading #7452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riuvshin
added
kind/bug
ghost
approved these changes
Nov 20, 2017
benoitf
added
the
status/code-review
|
@riuvshin should be issue the same PR against che6 branch? |
benoitf
approved these changes
Nov 20, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7057
We have an issue that new samples added to default samples.json in newversion won't be loaded after update. That PR makes sure that on each run of che-server it will use accurate samples right from the assembly.
Also it allows users to add their own samples in
templatesdir as separate files as we are now not deleting everythingrm -rf "${CHE_DATA}"/templates/*