CHE-745 Make plugin-svn build & run in Che #758
Conversation
|
Will we have svn support in Che enabled? |
|
Seems like a good idea. |
| } | ||
|
|
||
| private void refreshNodes(String forPath) { | ||
| // appContext.getCurrentProject().getCurrentTree().getNodeByPath(forPath, new AsyncCallback<TreeNode<?>>() { |
There was a problem hiding this comment.
No, this code is outdated to the new codebase in 4.x and need to be rewritten
There was a problem hiding this comment.
Deprecated code should be removed.
|
Can you confirm legal origin of all source code and images? |
|
Especially due to use of crypto algorithms |
| *******************************************************************************/ | ||
| package org.eclipse.che.api.crypt.server; | ||
|
|
||
| public interface EncryptTextServiceRegistry { |
There was a problem hiding this comment.
I'm adding the javadoc.
About the "legal origin" I guess that you want to be sure that the whole code was written by us and does not contain some copy/paste code. I asked Mickael (who created this encryption code) and he confirm that the whole code is from him. Not copy/paste. So no legal issue.
About copyright on images they were already double checked when we added them originally.
|
95% of this code is the same as the original SVN plugin that we had in Che 3. The other 5% is what I refactored to make the plugin compliant with Che 4.x. And I added no image or "critical" code. |
| /** | ||
| * The encryption services. | ||
| */ | ||
| private final Map<Integer, EncryptTextService> registry = new HashMap<>(); |
There was a problem hiding this comment.
better no create in constructor with known size
stour
force-pushed
the
CHE-745
branch
4 times, most recently
from
e5b0d6f
to
8d12599
Compare
|
@skabashnyuk @sleshchenko I applied changes related to your comments + other needed changes like creating separate submodules for server, ide and shared parts. |
|
Ok. to go after 4.0 |
|
|
||
| /** | ||
| * Extension adding <a href="http://subversion.apache.org">Subversion</a> support to the | ||
| * <a href="http://codenvy.com">Codenvy</a> IDE. |
There was a problem hiding this comment.
Rewrite comment without Codenvy
| * Interface providing access to localization constants. | ||
| * <p/> | ||
| * These are loaded from | ||
| * src/resources/org/eclipse/che/plugin/svn/SubversionExtensionLocalizationConstants.properties |
There was a problem hiding this comment.
Remove or rewrite this outdated comment. For now it locates in package org/eclipse/che/plugin/svn/ide
I prefer to remove it.
stour
force-pushed
the
CHE-745
branch
4 times, most recently
from
44901d5
to
251e1a8
Compare
Signed-off-by: Stéphane Tournié <stephane.tournie@serli.com>
|
ok |
This Pull Request:
See epic for details.