Fix the OpenshiftClient connection leaks #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... while reusing a common `OkHttpClient` instance as much as possible (not possible in some cases, like `startExec()`, that involve `InputStreamPumper` and broken pipes). Signed-off-by: David Festal <dfestal@redhat.com>
|
Can one of the admins verify this patch? |
benoitf
added
status/code-review
|
Can one of the admins verify this patch? |
ibuziuk
reviewed
Dec 8, 2017
| public OpenShiftClientFactory( | ||
| OpenshiftWorkspaceEnvironmentProvider workspaceEnvironmentProvider) { | ||
| this.httpClient = | ||
| HttpClientUtils.createHttpClient(workspaceEnvironmentProvider.getDefaultOpenshiftConfig()); |
There was a problem hiding this comment.
@davidfestal not sure, but formatting does not look right from the first glance
There was a problem hiding this comment.
well, it's formatted by the maven formatter plugin afaik
|
ci-build |
|
Build # 4379 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4379/ to view the results. |
Signed-off-by: David Festal <dfestal@redhat.com>
|
ci-build |
1 similar comment
|
ci-build |
Signed-off-by: David Festal <dfestal@redhat.com>
|
Build # 4381 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4381/ to view the results. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4383/ |
l0rd
approved these changes
Dec 12, 2017
ibuziuk
approved these changes
Dec 12, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the OpenshiftClient connection leaks ... while reusing a common
OkHttpClientinstance as much as possible (not possible in some cases, likestartExec(), that involveInputStreamPumperand broken pipes).What issues does this PR fix or reference?
This PR is related to the issue discussed here and here, as well as this initial issue of the
OpenshiftConnector: https://issues.jboss.org/browse/CHE-180It fixes these issues in a way that is compatible with the CHE-5-based OSIO multi-tenant server.