Fix invalid API version from openshift yml

[Themodem]

What does this PR do?

Quick sed fix for deployment to minishift.

Should probably be fixed in the maven2/io/fabric8/tenant/apps/che repo.

What issues does this PR fix or reference?

Closes #7803

Changelog

sed apps.openshift.io/ out of the version as its invalid when running deploy_che.sh

Release Notes

N/A

[codenvy-ci]

Can one of the admins verify this patch?

[codenvy-ci]

Can one of the admins verify this patch?

[l0rd]

Approving this because that's compatible with versions 3.5, 3.6 and 3.7 of OpenShift but that's not a bug, it's the new DeploymentConfig API endpoint introduced with OpenShift 3.6 (i.e. if you update your client and server the script should work fine).

[benoitf]

@Themodem You should sign Eclipse ECA and amend your commit with ECA Signed-Off by footer (currently the ip validation of this PR is failing)
https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=5a377e1bd6eac

[Themodem]

Hi @benoitf

Slightly confused about the ECA, the link provided by jenkins says my email address has not signed the ECA but if I look at the eclipse website that says I already have.

Am i missing another step?

Also the link from the jenkins webhook links to an out of date page

This page is deprecated and may contain some information that is no longer relevant or accurate.

[benoitf]

@Themodem yes you need to amend your commit with Signed-Off: footer

[Themodem]

@benoitf ahh my bad, figured it would use gpg key signing.

Amended the commit.

Cheers