CHE-7880: Save latest commit message before showing Git Commit dialog #8004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
added
the
kind/enhancement
vinokurig
added
the
status/code-review
tolusha
reviewed
Dec 22, 2017
| @@ -137,6 +142,9 @@ public void showDialog(Project project) { | |||
| newFiles.addAll(status.getUntracked()); | |||
| show(newFiles.stream().collect(joining("\nA\t", "A\t", ""))); | |||
| }); | |||
| } else { | |||
| view.setMessage(""); | |||
There was a problem hiding this comment.
I guess it isn't necessary.
tolusha
reviewed
Dec 22, 2017
| notificationManager.notify(constant.logFailed(), FAIL, NOT_EMERGE_MODE); | ||
| } | ||
| }); | ||
| if (latestCommitMessage == null) { |
There was a problem hiding this comment.
Just set focus to commit message text box
There was a problem hiding this comment.
Added setting focus to message field on clicking the amend checkbox.
tolusha
approved these changes
Dec 22, 2017
vparfonov
approved these changes
Dec 22, 2017
|
ci-test |
|
ci-test build report: |
|
ci-test |
|
ci-test build report: |
vinokurig
changed the title
|
ci-test |
|
ci-test build report: |
vinokurig
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Save latest commit message before showing Git Commit dialog
What issues does this PR fix or reference?
#7880
Latest commit message sets without delay when amend option is switched on in Git Commit dialog
Release Notes
N/A
Docs PR
N/A