Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check link availability in the CheckIntelligenceCommandFromToolbarTest selenium test #8063

Merged
merged 13 commits into from
Dec 27, 2017

Conversation

Ohrimenko1988
Copy link
Contributor

What does this PR do?

Add check link availability in the CheckIntelligenceCommandFromToolbarTest selenium test

What issues does this PR fix or reference?

Issue #8019

Release Notes

Docs PR

@Ohrimenko1988 Ohrimenko1988 added kind/bug Outline of a bug - must adhere to the bug report template. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Dec 27, 2017

consoles.clickOnPreviewUrl();
checkTestAppAndReturnToIde(currentWindow, "Enter your name:");
waitAndCheckPreviewUrlIsAvailable(currentWindow, "Enter your name");
Copy link
Contributor

@dmytro-ndp dmytro-ndp Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waitAndCheckPreviewUrlIsAvailable > waitOnAvailablePreviewPage

.until((ExpectedCondition<Boolean>) driver -> linkIsAvailable(currentWindow, expectedText));
}

private Boolean linkIsAvailable(String currentWindow, String expectedText) {
Copy link
Contributor

@dmytro-ndp dmytro-ndp Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkIsAvailable > isPreviewPageAvailable

@@ -125,4 +117,34 @@ private void checkTestAppAndReturnToIde(String currentWindow, String expectedTex
seleniumWebDriver.close();
seleniumWebDriver.switchTo().window(currentWindow);
}

private void waitAndCheckPreviewUrlIsAvailable(String currentWindow, String expectedText) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expectedText > expectedTextOnPreviewPage

@Ohrimenko1988 Ohrimenko1988 merged commit e94c343 into master Dec 27, 2017
@Ohrimenko1988 Ohrimenko1988 deleted the selenium-check-intelligence branch December 27, 2017 10:31
@Ohrimenko1988 Ohrimenko1988 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 27, 2017
@benoitf benoitf added this to the 6.0.0-M4 milestone Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants