-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LuceneSearcher redesign and fix memory leak #8112
Conversation
|
||
@BeforeMethod | ||
public void setUp() throws Exception { | ||
indexDirectory = Files.createTempDir(); // Paths.get("/tmp/indexdir").toFile(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment needed?
@@ -680,7 +692,7 @@ public ProjectSearchResponseDto search(ProjectSearchRequestDto request) { | |||
|
|||
try { | |||
return search(path, name, text, maxItems, skipCount); | |||
} catch (ServerException | ConflictException | NotFoundException | ForbiddenException e) { | |||
} catch (ServerException | NotFoundException | BadRequestException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it makes sense to throw these exceptions in other code to lose the information about exception type here.
…E_MAVEN__SERVER__JAVA__OPTIONS looks like for end user
ci-test |
ci-test build report: |
ci-test |
ci-test build report: |
ci-test |
ci-test build report: |
ci-test |
ci-test build report: |
ci-test |
ci-test build report: |
ci-test |
ci-test build report: |
What does this PR do?
LuceneSearcher redesign and fix memory leak
add
directory methodprintStatistic
method to put some statistics in log.debug outputdelete
method to the fact that is called after folder or file removalindexWriter.commit
after adding, update, removal of file or folderWhat issues does this PR fix or reference?
Fixes #8111
Release Notes
LuceneSearcher redesign and fix memory leak
Docs PR
n/a