Selenium: add checking that the Authorize button exists in the ImportProjectFromGitHubTest test #8142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/code-review
tolusha
requested changes
Jan 4, 2018
| @@ -116,11 +117,10 @@ private void connectGithubAccount() { | |||
| gitHub.typeLogin(gitHubUsername); | |||
| gitHub.typePass(gitHubPassword); | |||
| gitHub.clickOnSignInButton(); | |||
| loader.waitOnClosed(); | |||
| WaitUtils.sleepQuietly(5); | |||
There was a problem hiding this comment.
It is better to find another solution.
tolusha
reviewed
Jan 4, 2018
| @@ -247,6 +247,8 @@ public void waitAuthorizeBtn() { | |||
| /** click on authorize button */ | |||
| public void clickOnAuthorizeBtn() { | |||
| waitAuthorizeBtn(); | |||
| new WebDriverWait(seleniumWebDriver, 10) | |||
tolusha
approved these changes
Jan 4, 2018
SkorikSergey
changed the title
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds checking that the Authorize button exists in the ImportProjectFromGitHubTest test!