Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: add checking that the Authorize button exists in the ImportProjectFromGitHubTest test #8142

Merged
merged 4 commits into from
Jan 4, 2018
Merged

Selenium: add checking that the Authorize button exists in the ImportProjectFromGitHubTest test #8142

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4275fa1
adding timeout that the Autorization page is closed
Jan 3, 2018
0704343
added checking for the Authorize github button
SkorikSergey Jan 4, 2018
9be1ad7
"remove checking that the Login page is closed"
SkorikSergey Jan 4, 2018
474536c
used timeout constant in clickOnAuthorizeBtn() method of GitHub page …
Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...um-test/src/test/java/org/eclipse/che/selenium/dashboard/ImportProjectFromGitHubTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.eclipse.che.selenium.core.SeleniumWebDriver;
import org.eclipse.che.selenium.core.client.TestWorkspaceServiceClient;
import org.eclipse.che.selenium.core.user.TestUser;
import org.eclipse.che.selenium.core.utils.WaitUtils;
import org.eclipse.che.selenium.pageobject.GitHub;
import org.eclipse.che.selenium.pageobject.Loader;
import org.eclipse.che.selenium.pageobject.ProjectExplorer;
Expand Down Expand Up @@ -116,11 +117,10 @@ private void connectGithubAccount() {
gitHub.typeLogin(gitHubUsername);
gitHub.typePass(gitHubPassword);
gitHub.clickOnSignInButton();
loader.waitOnClosed();
WaitUtils.sleepQuietly(5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to find another solution.


// authorize on github.com
if (seleniumWebDriver.getWindowHandles().size() > 1) {
loader.waitOnClosed();
gitHub.waitAuthorizeBtn();
gitHub.clickOnAuthorizeBtn();
}
Expand Down