CHE-7040: Add 400 ms. delay in Navigate to file dialog #8177
Conversation
vinokurig
added
kind/enhancement
| () -> Log.error(getClass(), "Project search request failed due timeout")); | ||
| } | ||
| }; | ||
| timer.schedule(500); |
vinokurig
added
status/in-progress
|
ci-test |
vinokurig
changed the title
|
ci-test build report: |
| @@ -39,12 +39,16 @@ | |||
| @Singleton | |||
| public class NavigateToFilePresenter implements NavigateToFileView.ActionDelegate { | |||
|
|
|||
| private static final int TYPING_PERIOD_DELAY_MS = 400; | |||
There was a problem hiding this comment.
To me TYPING_REQUEST_DELAY_MS is clearer.
There was a problem hiding this comment.
It is not a request
There was a problem hiding this comment.
It is not a query. The idea is to identify that typing is not finished yet.
| } | ||
|
|
||
| private void prepareResults(ProjectSearchResponseDto response) { | ||
| List<SearchResultDto> results = response.getItemReferences(); | ||
| sort( | ||
| results, | ||
| results.sort( |
There was a problem hiding this comment.
Maybe it would be better to create static comparator?
| delegate.onFileNameChanged(fileName.getText()); | ||
| String fileName = NavigateToFileViewImpl.this.fileName.getText(); | ||
| // Skip handling non letter characters. | ||
| if (nativeKeyCode == KEY_BACKSPACE |
There was a problem hiding this comment.
We can check it before timer creation
There was a problem hiding this comment.
https://github.com/eclipse/che/blob/21e4f80341657048f1d6502792d1d642774d6377/ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/navigation/NavigateToFileViewImpl.java#L335-L336
I am not sure that the file name field will be ready to give text.
|
ci-test |
vinokurig
added
status/code-review
|
ci-test build report: |
vinokurig
removed
the
status/code-review
What does this PR do?
Add 400 ms. delay in the Navigate to file dialog. This prevents sending request to server if the file name field was updated during the timeout. Timeout in 500 ms. was chosen because It is enough to type a new symbol when typing a file name, and on the other hand this is not a big delay between end of typing and sending a request.
What issues does this PR fix or reference?
#7040
Prevent sending search request to server from Navigate to file dialog, if the file name field was updated.
Release Notes
N/A
Docs PR
N/A