Add info about known issue #8319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
status/code-review
vparfonov
approved these changes
Jan 16, 2018
dmytro-ndp
reviewed
Jan 16, 2018
| try { | ||
| assertTrue(instToRequestThread.get().contains("Sorry, you failed. Try again later!")); | ||
| } catch (AssertionError ex) { | ||
| LOG.error( |
There was a problem hiding this comment.
This log looks redundant here. What is the propose of it?
There was a problem hiding this comment.
In the log i try to add information from response. This important for clarify what happened when we do not get expected response from test application. So i change error on warn.
tolusha
approved these changes
Jan 17, 2018
dmytro-ndp
approved these changes
Jan 17, 2018
|
ci-build |
|
Build # 4420 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4420/ to view the results. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4423/ |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add info into the test about known issue and response data to error log.
What issues does this PR fix or reference?
#8105
@dmytro-ndp @tolusha @vparfonov