Dashboard: code clean-up

[akurinnoy]

What does this PR do?

This PR makes dashboard *.ts files compliant with typescript and tslint rules.

gulp build output:

Using remote Che server http://localhost:8080
[15:46:08] Using gulpfile ~/workspace/akurinnoy/che/dashboard/gulpfile.js
[15:46:08] Starting 'outputcolorstemplate'...
[15:46:08] Starting 'proxySettingsTemplate'...
[15:46:08] Starting 'colorstemplate'...
[15:46:08] Starting 'styles'...
[15:46:08] Starting 'partials'...
[15:46:08] Starting 'images'...
[15:46:08] Starting 'htmlassets'...
[15:46:08] Starting 'brandingassets'...
[15:46:08] Starting 'existingfonts'...
[15:46:08] Starting 'other'...
[15:46:09] Finished 'htmlassets' after 35 ms
[15:46:09] Finished 'proxySettingsTemplate' after 1.21 s
[15:46:09] Starting 'proxySettings'...
[15:46:09] Finished 'colorstemplate' after 1.22 s
[15:46:09] Starting 'colors'...
[15:46:09] Finished 'outputcolorstemplate' after 1.25 s
[15:46:09] Starting 'outputcolors'...
[15:46:09] Finished 'proxySettings' after 57 ms
[15:46:09] Finished 'colors' after 48 ms
[15:46:09] Starting 'scripts'...
[15:46:09] Finished 'outputcolors' after 214 ms
[15:46:09] Finished 'brandingassets' after 854 ms
[15:46:13] Finished 'images' after 4.25 s
[15:46:13] Finished 'existingfonts' after 4.79 s
[15:46:13] Starting 'fonts'...min
[15:47:16] gulp-inject 200 files into index.styl.
[15:47:21] gulp-autoprefixer: 
  autoprefixer: /home/okurinnyi/workspace/akurinnoy/che/dashboard/src/app/index.css:7159:3: Replace fill-available to stretch, because spec had been changed
  autoprefixer: /home/okurinnyi/workspace/akurinnoy/che/dashboard/src/app/index.css:7196:3: Replace fill-available to stretch, because spec had been changed
  autoprefixer: /home/okurinnyi/workspace/akurinnoy/che/dashboard/src/app/index.css:7293:3: Replace fill-available to stretch, because spec had been changed
[15:47:22] Finished 'styles' after 1.22 min
[15:47:22] Starting 'inject'...
[15:47:22] gulp-inject 1 files into 404.html.
[15:47:22] gulp-inject 1 files into 404.html.
[15:47:22] gulp-inject 1 files into gitHubCallback.html.
[15:47:22] gulp-inject 1 files into gitHubCallback.html.
[15:47:22] gulp-inject 1 files into index.html.
[15:47:22] gulp-inject 1 files into index.html.
[15:47:22] Finished 'fonts' after 1.13 min
[15:47:22] Finished 'inject' after 120 ms
[15:47:23] Finished 'partials' after 1.23 min
[15:47:23] Starting 'html'...
[15:47:23] gulp-inject 1 files into 404.html.
[15:47:23] gulp-inject 1 files into gitHubCallback.html.
[15:47:23] gulp-inject 1 files into index.html.
[15:47:30] target/dist/ maps/scripts/app-6d1c9a4ca8.js.map 885.93 kB
[15:47:34] target/dist/ maps/styles/app-6e036bb6e9.css.map 293.49 kB
[15:47:49] target/dist/ maps/scripts/vendor-73784b1bca.js.map 1.81 MB
[15:47:49] target/dist/ scripts/app-6d1c9a4ca8.js 1.36 MB
[15:47:49] target/dist/ styles/app-6e036bb6e9.css 723.6 kB
[15:47:49] target/dist/ scripts/vendor-73784b1bca.js 1.27 MB
[15:47:49] target/dist/ 404.html 4.27 kB
[15:47:49] target/dist/ gitHubCallback.html 56 B
[15:47:49] target/dist/ index.html 1.87 kB
[15:47:49] target/dist/ all files 6.34 MB
[15:47:49] Finished 'html' after 26 s
[15:47:49] Finished 'other' after 1.67 min
[15:47:49] Starting 'build'...
[15:47:49] Finished 'build' after 6.76 μs

[akurinnoy]

ci-test

[codenvy-ci]

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8333
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[akurinnoy]

ci-test

[codenvy-ci]

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8333
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.