Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: improve a workspace creation flow #8338

Merged
merged 5 commits into from
Jan 18, 2018

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Once a workspace is created the user can either open Workspace Details page to continue editing the workspace or open it in IDE.
For this purpose, the 'Create' button at the top of Create Workspace page is replaced with a drop-down button:
screenshot-localhost-3000-2018-01-17-16-40-00-490

The click on 'Create' button at the bottom of the page opens a modal window with two options: edit workspace on Workspace Details page or open it in IDE:
screenshot-localhost-3000-2018-01-17-16-44-30-496

What issues does this PR fix or reference?

resolves #8167

Release Notes

Docs PR

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
…icked

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. labels Jan 17, 2018
@akurinnoy akurinnoy self-assigned this Jan 17, 2018
@akurinnoy
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8338
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Copy link
Contributor

@ashumilova ashumilova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dealt to remove unused dropdown button and have new one without "2" index

@ashumilova ashumilova added this to the 6.0.0-M5 milestone Jan 18, 2018
- remove che-button-dropdown
- rename che-button-dropdown2 => che-button-dropdown

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy changed the title [WIP] Dashboard: improve a workspace creation flow Dashboard: improve a workspace creation flow Jan 18, 2018
SkorikSergey pushed a commit that referenced this pull request Jan 18, 2018
@akurinnoy akurinnoy merged commit 6579ec7 into eclipse-che:master Jan 18, 2018
@akurinnoy akurinnoy deleted the CHE-8167 branch August 23, 2018 10:21
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
* add che-button-dropdown2 directive and unit tests

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* replace "Create" button with dropdown button in top of Create WS page

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* add after-creation-dialog component, show it on 'Create' button is clicked

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* replace unused dropdown component with new one

- remove che-button-dropdown
- rename che-button-dropdown2 => che-button-dropdown

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix aligning

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace always run after creation
5 participants