-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: improve a workspace creation flow #8338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
…icked Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
ci-test |
benoitf
approved these changes
Jan 17, 2018
ci-test build report: |
ashumilova
approved these changes
Jan 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dealt to remove unused dropdown button and have new one without "2" index
olexii4
approved these changes
Jan 18, 2018
- remove che-button-dropdown - rename che-button-dropdown2 => che-button-dropdown Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
SkorikSergey
pushed a commit
that referenced
this pull request
Jan 18, 2018
This was referenced Jan 18, 2018
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* add che-button-dropdown2 directive and unit tests Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * replace "Create" button with dropdown button in top of Create WS page Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * add after-creation-dialog component, show it on 'Create' button is clicked Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * replace unused dropdown component with new one - remove che-button-dropdown - rename che-button-dropdown2 => che-button-dropdown Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fix aligning Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/enhancement
A feature request - must adhere to the feature request template.
status/in-progress
This issue has been taken by an engineer and is under active development.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Once a workspace is created the user can either open Workspace Details page to continue editing the workspace or open it in IDE.
![screenshot-localhost-3000-2018-01-17-16-40-00-490](https://user-images.githubusercontent.com/16220722/35050970-c9353f6c-fbac-11e7-927f-a150b7eb691e.png)
For this purpose, the 'Create' button at the top of Create Workspace page is replaced with a drop-down button:
The click on 'Create' button at the bottom of the page opens a modal window with two options: edit workspace on Workspace Details page or open it in IDE:
![screenshot-localhost-3000-2018-01-17-16-44-30-496](https://user-images.githubusercontent.com/16220722/35051062-09b328d8-fbad-11e7-8cf2-e2af26e0f358.png)
What issues does this PR fix or reference?
resolves #8167
Release Notes
Docs PR