-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenium: adapt selenium tests according to changes in a workspace creation flow #8349
Conversation
@@ -181,7 +182,7 @@ public void clickOnSaveChangesBtn() { | |||
} | |||
|
|||
public void clickOnCancelChangesBtn() { | |||
loader.waitOnClosed(); | |||
WaitUtils.sleepQuietly(3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, comment sleep here and why we need exact 3 seconds.
.click(); | ||
} | ||
|
||
public void clickOnCreateButtonAndStartWorkspace() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the commands inside, the method name should be "clickOnCreateButtonAndOpenInIDE"
…uttonAndOpenInIDE
What does this PR do?
This PR adapts selenium tests, that create a new workspace from the Dashboard, after changing a workspace creation flow by #8338.
This PR will be merged after #8338.
What issues does this PR fix or reference?
#8348