Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Create selenium tests to cover the authorization on GitHub #8395

Merged
merged 4 commits into from
Jan 26, 2018
Merged

Selenium: Create selenium tests to cover the authorization on GitHub #8395

merged 4 commits into from
Jan 26, 2018

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Create the selenium test 'AuthorizeGithubFromDashboardTest'
  • Create the selenium test 'AuthorizeGithubFromPreferencesTest'
  • Create the selenium test 'AuthorizeOnGithubFromImportTest'
  • Add the method 'waitGithubProjectList()' to the 'ProjectSourcePage'

What issues does this PR fix or reference?

#8325, #8345, #8360

@artaleks9
Create selenium tests to cover the authorization on GitHub
cdcfcba 
Create the selenium test 'AuthorizeGithubFromDashboardTest'
Create the selenium test 'AuthorizeGithubFromPreferencesTest'
Create the selenium test 'AuthorizeOnGithubFromImportTest'
Add the method 'waitGithubProjectList()' to the 'ProjectSourcePage'
@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/production labels Jan 22, 2018
@artaleks9
Copy link
Contributor Author

artaleks9 commented Jan 22, 2018 •
edited
Loading

Before merge we need to do next issue: #8310

@artaleks9 artaleks9 added status/pending-merge and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 22, 2018
@dmytro-ndp
Copy link
Contributor

@tolusha, @artaleks9: please, review fresh commit 0721436

@dmytro-ndp
Copy link
Contributor

ci-test-ocp

@dmytro-ndp dmytro-ndp removed their request for review January 25, 2018 15:56
@codenvy-ci
Copy link

codenvy-ci commented Jan 25, 2018 •
edited by dmytro-ndp
Loading

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8395
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Notes from @dmytro-ndp:

There were problems with start of test workspaces at OCP server side #8031:

2018-01-25 18:31:00,670[aceSharedPool-2] [WARN ] [w.i.o.OpenShiftInternalRuntime 150] - Failed to start OpenShift runtime of workspace workspaceger77d6cpswznkgt. Cause: Failure executing: POST at: https://172.30.3.246:8443/api/v1/namespaces/workspaceger77d6cpswznkgt/pods. Message: No API token found for service account "default", retry after the token is automatically created and added to the service account. Received status: Status(apiVersion=v1, code=500, details=StatusDetails(causes=[], group=null, kind=serviceaccounts, name=create pod, retryAfterSeconds=1, uid=null, additionalProperties={}), kind=Status, message=No API token found for service account "default", retry after the token is automatically created and added to the service account, metadata=ListMeta(resourceVersion=null, selfLink=null, additionalProperties={}), reason=ServerTimeout, status=Failure, additionalProperties={}).

org eclipse che selenium dashboard createanddeleteprojectstest createanddeleteprojecttest_o4x6hhiw

2018-01-25 22:22:10,490[aceSharedPool-6] [WARN ] [w.i.o.OpenShiftInternalRuntime 150] - Failed to start OpenShift runtime of workspace workspacen3nvcb1ajbokc4bs. Cause: Server 'wsagent/http' in machine 'dev-machine' not available.

@artaleks9
Copy link
Contributor Author

Report looks good, I approve

@dmytro-ndp dmytro-ndp merged commit d7ac674 into master Jan 26, 2018
@dmytro-ndp dmytro-ndp deleted the che#8310 branch January 26, 2018 09:39
@dmytro-ndp dmytro-ndp added this to the 6.0.0-M5 milestone Jan 26, 2018
hkolvenbach pushed a commit to hkolvenbach/che that referenced this pull request Mar 2, 2018
Merge pull request eclipse-che#5 in CLD/slx.cloud-che from abhi.CHE6_…
66adb94 
…migration to master

* commit '47fe46a34fa1df988ed61d46e5a478e0f67675b7': (156 commits)
  Fixed build errors
  eclipse-che#6331 disable key binding handle when any 'Window' opened (eclipse-che#8473)
  changed info about known issue (eclipse-che#8483)
  Avoid removal of non-test workspaces at the cleanup environment stage of selenium testing (eclipse-che#8481)
  Add changes in the methods of checking git-marker in the page object 'CodenvyEditor'
  updated the command
  Use nightly stack by default and -Pdev for development
  Changes pvc name to a prefix + 8 random characters
  init and cli images should not use tag from CHE (eclipse-che#8474)
  CHE-7581 Improved keycloak initialization (eclipse-che#8425)
  CHE-8240: Switch to project explorer tab for reavel resources action. (eclipse-che#8460)
  Selenium: Create selenium tests to cover the authorization on GitHub (eclipse-che#8395)
  apply formating for 'CreateNewPackagesWithHelpCreationJavaClassTest' selenium test (eclipse-che#8464)
  remove read 'preferences' in try/catch block (eclipse-che#8463)
  add project build to CheckAutocompleteFeaturesInTheTestFolderTest (eclipse-che#8457)
  Selenium: Add try/catch block for displaying "Known issue" with eclipse-che#8300 bug (eclipse-che#8454)
  add info about known issue to FileStructureNodesTest selenium test (eclipse-che#8452)
  Remove "source" field from stack object (eclipse-che#8407)
  Selenium: Fix unexpected fail of MacrosCommandsEditorTest selenium test (eclipse-che#8441)
  Fix formatting (eclipse-che#8447)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.0.0-M5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@artaleks9 @dmytro-ndp @codenvy-ci @tolusha @SkorikSergey