Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-7581 Improved keycloak initialization #8425

Merged
merged 4 commits into from
Jan 26, 2018
Merged

CHE-7581 Improved keycloak initialization #8425

merged 4 commits into from
Jan 26, 2018

Conversation

vitaliy-guliy
Copy link
Contributor

What does this PR do?

Improves keycloak initialization.

What issues does this PR fix or reference?

#7581

Release Notes

Docs PR

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Jan 24, 2018
* Load keycloak settings
*/
this.loadKeycloakSettings = function() {
var msg = "Cannot load keycloak settings";
Copy link
Contributor

@mshaposhnik mshaposhnik Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add explanation in message that this is normal sutuation for single-user mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@vitaliy-guliy
Copy link
Contributor Author

ci-build

@codenvy-ci
Copy link

@vitaliy-guliy
Copy link
Contributor Author

ci-test

@ashumilova ashumilova added this to the 6.0.0-M5 milestone Jan 24, 2018
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8425
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vitaliy-guliy vitaliy-guliy merged commit 9abfec7 into master Jan 26, 2018
@vitaliy-guliy vitaliy-guliy deleted the CHE-7581 branch January 26, 2018 10:35
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 26, 2018
hkolvenbach pushed a commit to hkolvenbach/che that referenced this pull request Mar 2, 2018
…migration to master

* commit '47fe46a34fa1df988ed61d46e5a478e0f67675b7': (156 commits)
  Fixed build errors
  eclipse-che#6331 disable key binding handle when any 'Window' opened (eclipse-che#8473)
  changed info about known issue (eclipse-che#8483)
  Avoid removal of non-test workspaces at the cleanup environment stage of selenium testing (eclipse-che#8481)
  Add changes in the methods of checking git-marker in the page object 'CodenvyEditor'
  updated the command
  Use nightly stack by default and -Pdev for development
  Changes pvc name to a prefix + 8 random characters
  init and cli images should not use tag from CHE (eclipse-che#8474)
  CHE-7581 Improved keycloak initialization (eclipse-che#8425)
  CHE-8240: Switch to project explorer tab for reavel resources action. (eclipse-che#8460)
  Selenium: Create selenium tests to cover the authorization on GitHub (eclipse-che#8395)
  apply formating for 'CreateNewPackagesWithHelpCreationJavaClassTest' selenium test (eclipse-che#8464)
  remove read 'preferences' in try/catch block (eclipse-che#8463)
  add project build to CheckAutocompleteFeaturesInTheTestFolderTest (eclipse-che#8457)
  Selenium: Add try/catch block for displaying "Known issue" with eclipse-che#8300 bug (eclipse-che#8454)
  add info about known issue to FileStructureNodesTest selenium test (eclipse-che#8452)
  Remove "source" field from stack object (eclipse-che#8407)
  Selenium: Fix unexpected fail of MacrosCommandsEditorTest selenium test (eclipse-che#8441)
  Fix formatting (eclipse-che#8447)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants