Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-4927 fix light theme colors #8418

Merged
merged 1 commit into from
Jan 25, 2018
Merged

CHE-4927 fix light theme colors #8418

merged 1 commit into from
Jan 25, 2018

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 23, 2018 •
edited
Loading

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix light theme colors.

What issues does this PR fix or reference?

#4927

Release Notes

  -- fix light theme colors.

Docs PR

selection_103
selection_094
selection_093

@olexii4 olexii4 added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 23, 2018
@olexii4 olexii4 removed the request for review from akurinnoy January 23, 2018 12:14
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 23, 2018
@olexii4
Copy link
Contributor Author

olexii4 commented Jan 23, 2018

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8418
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

slemeur
slemeur approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

vparfonov
vparfonov reviewed Jan 24, 2018
View reviewed changes
ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/theme/DarkTheme.java
@@ -1865,4 +1890,99 @@ public String projectExplorerPlaceholderIconColor() {
public String projectExplorerPlaceholderRowColor() {
return "#333846";
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of new items for colors, i think we need to decrease color values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert it and use theme defined constants? I'm worry text will become partially unreadable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the workspace status panel can not be customized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use so many constants as we have. The best way - using only 5...6 custom colors for this widget (kind of Grey, Yellow, Blue, Green, Red).

done

@ashumilova ashumilova requested review from vitaliy-guliy and removed request for ashumilova January 24, 2018 12:39
@olexii4
CHE-4927 fix light theme styles
4493896 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 added this to the 6.0.0-M5 milestone Jan 25, 2018
@olexii4 olexii4 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 25, 2018
@olexii4 olexii4 merged commit db67256 into master Jan 25, 2018
@olexii4 olexii4 deleted the CHE-4927 branch January 25, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@benoitf benoitf benoitf approved these changes

@evidolob evidolob evidolob approved these changes

@dkuleshov dkuleshov dkuleshov approved these changes

@vparfonov vparfonov vparfonov approved these changes

@slemeur slemeur slemeur approved these changes

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.0.0-M5
Development

Successfully merging this pull request may close these issues.
8 participants
@olexii4 @codenvy-ci @benoitf @evidolob @dkuleshov @vparfonov @slemeur @vitaliy-guliy