Selenium: change locator for documentation link on the Dashboard #8443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/code-review
dmytro-ndp
reviewed
Jan 25, 2018
| @@ -49,7 +49,7 @@ public Workspaces(SeleniumWebDriver seleniumWebDriver, Dashboard dashboard) { | |||
|
|
|||
| private interface Locators { | |||
| String TOOLBAR = "Workspaces"; | |||
| String DOCUMENTATION_LINK = "//a[@ng-href='/docs/devops/intro/index.html']"; | |||
| String DOCUMENTATION_LINK = "//a[@ng-href='/docs/what_are_workspaces.html']"; | |||
There was a problem hiding this comment.
Let's rewrite the test not to depend on value of documentation link.
tolusha
approved these changes
Jan 25, 2018
dmytro-ndp
approved these changes
Jan 25, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes locator for documentation link on the Dashboard.
