Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Explorer UI improvements #8581

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Command Explorer UI improvements #8581

merged 2 commits into from
Feb 6, 2018

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Feb 2, 2018

What does this PR do?

This changes proposal adds a context menu to Command Explorer; handle Delete key press to perform command delete, small UI improvements.

image

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

#7715

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/plugin labels Feb 2, 2018
@vzhukovs vzhukovs self-assigned this Feb 2, 2018
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import static org.eclipse.che.ide.api.action.IdeActions.GROUP_TOOLBAR_CONTROLLER;
import static org.eclipse.che.ide.api.action.IdeActions.GROUP_WORKSPACE;
import static org.eclipse.che.ide.api.action.IdeActions.TOOL_WINDOWS_GROUP;
import static org.eclipse.che.ide.api.action.IdeActions.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not using wildcard imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@ashumilova ashumilova added this to the 6.1.0 milestone Feb 5, 2018
@vzhukovs
Copy link
Contributor Author

vzhukovs commented Feb 6, 2018

ci-build

@codenvy-ci
Copy link

@vzhukovs vzhukovs merged commit 4f9994e into master Feb 6, 2018
@vzhukovs vzhukovs deleted the che#7715 branch February 6, 2018 09:15
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants