Selenium: fix unstable CheckStopStartWsTest selenium test #8640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
kind/bug
artaleks9
approved these changes
Feb 7, 2018
dmytro-ndp
reviewed
Feb 7, 2018
| terminal.waitTerminalTab(LOADER_TIMEOUT_SEC); | ||
| loader.waitOnClosed(); | ||
| terminal.waitTerminalTab(EXPECTED_MESS_IN_CONSOLE_SEC); | ||
| menu.waitMenuItemIsEnabled(PROFILE_MENU); |
There was a problem hiding this comment.
This verification slightly duplicates another one in test CreateWorkspaceOnDashboardTest.
To avoid duplication and to have one place to change verification in future, I would suggest moving the next commands from the test CreateWorkspaceOnDashboardTest to separate method Ide::waitOpenedWorkspaceIsReadyToUse() and use it instead:
projectExplorer.waitProjectExplorer(PREPARING_WS_TIMEOUT_SEC); // we need long timeout for OSIO
terminal.waitTerminalTab(PREPARING_WS_TIMEOUT_SEC); // we need long timeout for OSIO
menu.waitMenuItemIsEnabled(WORKSPACE);
dmytro-ndp
reviewed
Feb 7, 2018
|
|
||
| toastLoader.clickOnStartButton(); | ||
| loader.waitOnClosed(); | ||
| projectExplorer.waitProjectExplorer(); |
There was a problem hiding this comment.
same comment as here https://github.com/eclipse/che/pull/8640/files#r166551388
added 2 commits
February 7, 2018 10:58
…StopStartWsTest
…e is fully started
dmytro-ndp
approved these changes
Feb 7, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix CheckStopStartWsTest selenium test :
What issues does this PR fix or reference?
#8647