-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenium: fix unstable CheckStopStartWsTest selenium test #8640
Conversation
terminal.waitTerminalTab(LOADER_TIMEOUT_SEC); | ||
loader.waitOnClosed(); | ||
terminal.waitTerminalTab(EXPECTED_MESS_IN_CONSOLE_SEC); | ||
menu.waitMenuItemIsEnabled(PROFILE_MENU); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This verification slightly duplicates another one in test CreateWorkspaceOnDashboardTest.
To avoid duplication and to have one place to change verification in future, I would suggest moving the next commands from the test CreateWorkspaceOnDashboardTest to separate method Ide::waitOpenedWorkspaceIsReadyToUse()
and use it instead:
projectExplorer.waitProjectExplorer(PREPARING_WS_TIMEOUT_SEC); // we need long timeout for OSIO
terminal.waitTerminalTab(PREPARING_WS_TIMEOUT_SEC); // we need long timeout for OSIO
menu.waitMenuItemIsEnabled(WORKSPACE);
|
||
toastLoader.clickOnStartButton(); | ||
loader.waitOnClosed(); | ||
projectExplorer.waitProjectExplorer(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as here https://github.com/eclipse/che/pull/8640/files#r166551388
…StopStartWsTest
…e is fully started
What does this PR do?
This PR fix CheckStopStartWsTest selenium test :
What issues does this PR fix or reference?
#8647