Fix webapp startup if no docker IP's set. #8655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
kind/bug
sleshchenko
reviewed
Feb 7, 2018
| @Nullable @Named("che.docker.ip") String internalIpOfContainers, | ||
| @Named("che.port") int chePort, | ||
| @Nullable @Named("che.docker.ip.external") String externalIpOfContainers, | ||
| @Nullable @Named("che.singleport.wildcard_domain.host") String wildcardHost) { | ||
| if (internalIpOfContainers == null && externalIpOfContainers == null) { | ||
| if (isSinglePortEnabled && internalIpOfContainers == null && externalIpOfContainers == null) { |
There was a problem hiding this comment.
Can we move this check into SinglePortHostnameBuilder?
sleshchenko
reviewed
Feb 7, 2018
| @Nullable @Named("che.docker.ip") String internalIpOfContainers, | ||
| @Nullable @Named("che.docker.ip.external") String externalIpOfContainers, | ||
| @Nullable @Named("che.docker.network") String dockerNetwork, | ||
| @Nullable @Named("che.singleport.wildcard_domain.host") String wildcardHost) { | ||
| if (internalIpOfContainers == null && externalIpOfContainers == null) { | ||
| if (isSinglePortEnabled && internalIpOfContainers == null && externalIpOfContainers == null) { | ||
| throw new IllegalStateException( |
There was a problem hiding this comment.
I think ConfigurationException would be better here.
sleshchenko
approved these changes
Feb 8, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix webapp startup if no docker_ip or external_docker_ip is set. That can be possible when running without CLI.
What issues does this PR fix or reference?
N//A
Release Notes
N/A
Docs PR
N/A