Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium: wait that all notifications are closed before deleting project in CreateAndDeleteProjectsTest test #8676

Merged
merged 2 commits into from
Feb 8, 2018

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

This PR adds checking that all notifications is closed before deleting project from workspace details in unstable CreateAndDeleteProjectsTest selenium test. It seems that checking that the created projects have the status PROJECT_FOLDER does not mean that the projects are initialized and we need to wait for all notifications to close.

Report with reproduced problem:
https://ci.codenvycorp.com/view/qa/job/che-integration-tests-master-docker/173/Selenium_tests_report/

Log:

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for visibility of element located by By.xpath: //button/span[text()='Delete'] (tried for 5 second(s) with 500 MILLISECONDS interval)
Build info: version: '3.0.1', revision: '1969d75', time: '2016-10-18 09:49:13 -0700'
System info: host: 'slave6.codenvycorp.com', ip: '127.0.0.1', os.name: 'Linux', os.arch: 'amd64', os.version: '3.10.0-514.16.1.el7.x86_64', java.version: '1.8.0_102'
Driver info: org.eclipse.che.selenium.core.SeleniumWebDriver
	at org.eclipse.che.selenium.dashboard.CreateAndDeleteProjectsTest.createAndDeleteProjectTest(CreateAndDeleteProjectsTest.java:102)

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. team/che-qe labels Feb 8, 2018
@@ -91,6 +91,7 @@ public void createAndDeleteProjectTest() throws ExecutionException, InterruptedE
mavenPluginStatusBar.waitClosingInfoPanel();
explorer.waitFolderDefinedTypeOfFolderByPath(CONSOLE_JAVA_SIMPLE, PROJECT_FOLDER);
explorer.waitFolderDefinedTypeOfFolderByPath(WEB_JAVA_SPRING, PROJECT_FOLDER);
notificationsPopupPanel.waitPopUpPanelsIsClosed();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, correct the method name waitPopUpPanelsIsClosed > waitPopupPanelsAreClosed

… NotificationsPopupPanel selenium page object
@SkorikSergey SkorikSergey merged commit 4f3b160 into master Feb 8, 2018
@SkorikSergey SkorikSergey deleted the fixCreateAndDeleteProjectsTest branch February 8, 2018 12:41
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 8, 2018
@benoitf benoitf added this to the 6.1.0 milestone Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants