Selenium: increase timeout for checking workspace statuses on Workspaces list #8681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
kind/bug
SkorikSergey
changed the title
dmytro-ndp
reviewed
Feb 8, 2018
| @@ -101,7 +102,7 @@ public String getWorkspaceStatus(String workspaceName) { | |||
| } | |||
|
|
|||
| public void waitWorkspaceStatusIs(String workspaceName, String workspaceStatus) { | |||
There was a problem hiding this comment.
Ended "Is" looks strange at the end of method name. Could you, please, remove it?
dmytro-ndp
reviewed
Feb 8, 2018
| @@ -101,7 +102,7 @@ public String getWorkspaceStatus(String workspaceName) { | |||
| } | |||
|
|
|||
| public void waitWorkspaceStatusIs(String workspaceName, String workspaceStatus) { | |||
| new WebDriverWait(seleniumWebDriver, EXPECTED_MESS_IN_CONSOLE_SEC) | |||
| new WebDriverWait(seleniumWebDriver, PREPARING_WS_TIMEOUT_SEC) | |||
There was a problem hiding this comment.
This is a kind of bottleneck for OCP, which worth to be commented, IMHO.
dmytro-ndp
reviewed
Feb 8, 2018
| @@ -240,7 +241,7 @@ public void waitWorkspaceIsPresent(String workspaceName) { | |||
|
|
|||
| /** wait the workspace is not present on dashboard */ | |||
| public void waitWorkspaceIsNotPresent(String workspaceName) { | |||
| new WebDriverWait(seleniumWebDriver, LOADER_TIMEOUT_SEC) | |||
| new WebDriverWait(seleniumWebDriver, EXPECTED_MESS_IN_CONSOLE_SEC) | |||
There was a problem hiding this comment.
This is a kind of bottleneck for OCP, which worth to be commented, IMHO.
dmytro-ndp
approved these changes
Feb 8, 2018
SkorikSergey
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR increases timeouts for checking workspace statuses on Dashboard.
What issues does this PR fix or reference?
#8677