Remove exec/terminal agents from dependencies of ws-agent

[skabashnyuk]

What does this PR do?

Remove exec/terminal agents from dependencies of ws-agent

What issues does this PR fix or reference?

Fixes #7482

Remove exec/terminal agents from dependencies of ws-agent

Release Notes

Remove exec/terminal agents from dependencies of ws-agent
This PR introduces some changes in behavior. Previously if you enable ws-agent installer
it also enables you terminal and exec agent even if you don't need it. After this pr that is no longer happen. You have to explicitly define terminal and exec agents. Fix in case someone wants terminal and exec agent, as well as ws-agent, is very simple: go to dashboard and enable terminal and(or) exec-agent.

Docs PR

n/a

[skabashnyuk]

ci-test

[garagatyi]

Have you considered making this PR backward compatible?

[skabashnyuk]

I don't see any backward compatible problems. Do you?

[codenvy-ci]

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8717
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[garagatyi]

@skabashnyuk I do. Currently, enabling of ws-agent without enabling terminal and exec agents enables last ones. After your PR it won't be true that may influence some workspaces.
I do not say that we should add migration in this PR, but I say this out loud to start discussion to consider whether any migration or backward compatibility tool is needed.

[skabashnyuk]

ok. We may include a note about that we are going to change this behavior in this release and change it in a next release. As a backward compatibility user may include an old version of ws-agent installer.

[garagatyi]

@skabashnyuk sounds reasonable to me.

[garagatyi]

@skabashnyuk I think that this PR description contains release notes section where you can describe this

[garagatyi]

@skabashnyuk Maybe you can add it in the PR - then it will be straightforward that release process responsible ppl are in charge of documenting it in the release information

[dmytro-ndp]

@Ohrimenko1988: shouldn't we add "org.eclipse.che.exec" into the installers list in next test factory templates as well?

• factory/docker/minimal.json
• factory/openshift/minimal.json

[skabashnyuk]

ci-test

[codenvy-ci]

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8717
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[skabashnyuk]

ci-test

[codenvy-ci]

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8717
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.