Theia docker file with launcher script #8732

evidolob · 2018-02-12T14:08:08Z

What does this PR do?

add Docker file with Theia and launcher script that can rebuild Theia with provided set of the plugin.

What issues does this PR fix or reference?

#8701

Release Notes

Docs PR

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

…ible to avoid building it if no plugins are requested from user

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

benoitf · 2018-02-12T14:38:37Z

dockerfiles/theia/Dockerfile

@@ -0,0 +1,20 @@
+FROM node:8-alpine


could you add Copyright headers .

benoitf · 2018-02-12T14:39:59Z

dockerfiles/theia/Dockerfile

+WORKDIR /home/theia
+# build Theia with all extensions to persist yarn cache in the image and
+# have default Theia build in the workspace in case no plugins are requested
+ADD theia-full-package.json /home/theia/package.json


it looks like there is a fork of upstream package.json, how to be in sync with upstream changes automatically ?

I think we can have two options here:

curl original Theia package.json as a Dockerfile instruction

Rely on our CI to do this after a triggered webhook.

having the github URL of theia package.json will allow to only re-run the RUN instruction only if the remote side is updated

(so we can reuse layer cache if there is no remote change)

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

benoitf · 2018-02-13T07:27:58Z

dockerfiles/theia/theia-default-package.json

+    "devDependencies": {
+        "@theia/cli": "latest"
+    }
+}


could you please add missing eof line

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

benoitf · 2018-02-13T08:36:18Z

dockerfiles/theia/Dockerfile

+EXPOSE 3000
+ENV USE_LOCAL_GIT=true \
+    GITHUB_TOKEN=957257352ad57b7853c8b8714d2201bf4d337b5e
+#    ENV THEIA_PLUGINS=[\"@theia\/extension-manager\",\"\@theia\/python\"]


should we remove this comment ?

we leave it for testing purpose, but we also can use -e THEIA_PLUGINS=... for this, so I remove it

@evidolob you may add a README or in the header of Dockerfile on how to use that image

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

riuvshin · 2018-02-13T12:45:00Z

dockerfiles/theia/Dockerfile

+    yarn theia build
+EXPOSE 3000
+ENV USE_LOCAL_GIT=true \
+    GITHUB_TOKEN=957257352ad57b7853c8b8714d2201bf4d337b5e


I do not think that this is a good idea to put someone's token in dockerfile, I think it user should pass it's own GH token if that is necessary

Sure it's not good. But at this point we don't have any way to get user's token

roblourens/vscode-ripgrep#4

What about https://docs.docker.com/engine/reference/builder/#environment-replacement?

@l0rd how does that help? The scenario is as follows:

Theia image starts, we have a running container

A node script checks for Theia plugins env and once found runs yarn and yarn theia build against a generated or existing package.json. It is during this build that a token is required.

Maybe I don't understand smth about env replacement.

@eivantsov sorry I meant https://docs.docker.com/engine/reference/commandline/run/#set-environment-variables--e-env-env-file

@eivantsov we don't need to get token, user should pass it
if you need token in runtime just pass it with docker run -e GITHUB_TOKEN=, if you need token for docker build you can do

+ARG GITHUB_TOKEN +ENV GITHUB_TOKEN ${GITHUB_TOKEN}

docker build --build-arg GITHUB_TOKEN=<token>

A user will just launch a workspace. It is us who do docker run, Che server I mean.

ahh, I thought it is image for CI, because all images we have in dockerfiles/ are for CLI and they are supposed to be built on CI. if that is image for WS maybe it should be moved to github.com/eclipse/che-dockerfiles ?

benoitf · 2018-02-13T12:58:58Z

based on demo, could it be possible to give

-e THEIA_PLUGINS="@theia/extension-manager,@theia/python"

instead of

-e THEIA_PLUGINS=[\"@theia\/extension-manager\",\"\@theia\/python\"]

ghost · 2018-02-13T13:00:12Z

@benoitf it was just easier to parse it :) Format and delivery method for plugins list is to be further discussed.

benoitf · 2018-02-13T13:00:54Z

@eivantsov but humans are not good parsers :-)

ghost · 2018-02-13T13:01:44Z

Easier for node script. So, we agreed to start with ["",""]

evidolob · 2018-02-13T13:03:12Z

@benoitf We never consider that user will manually edit that property, we should get good UI in dashboard for that

benoitf · 2018-02-13T13:06:08Z

let myPlugins="@theia/extension-manager,@theia/python"
var array = myPlugins.split(',');
var jsonString = JSON.stringify(array);
console.log('json array is', jsonString);

==> json array is ["@theia/extension-manager","@theia/python"]

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

evidolob · 2018-02-14T08:28:38Z

Now plugin list should provided as @benoitf proposed.
Example: -e THEIA_PLUGINS=@theia/python,@theia/go

ghost · 2018-02-14T11:36:29Z

Even though this is a stack image, we will probably need it to be versioned and updated on a regular basis.

l0rd · 2018-02-26T18:12:23Z

By the way @eivantsov it would be nice if all Che runtime stacks images could be versioned too. But that's another story :-)

* eclipse-che#8701 create launcher for theia Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

evidolob and others added 4 commits February 12, 2018 12:58

#8701 create launcher for theia

a620f19

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

#8701 fix exec call, check plugin string is empty or undefined

5cfebbb

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Optimize Dockerfile. Build and save default Theia which makes it poss…

63b767e

…ible to avoid building it if no plugins are requested from user

#8701 use default package.json instead of hardcoded

96fd5af

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

evidolob requested review from benoitf and riuvshin as code owners February 12, 2018 14:08

evidolob self-assigned this Feb 12, 2018

evidolob requested a review from ashumilova February 12, 2018 14:08

benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 12, 2018

benoitf reviewed Feb 12, 2018

View reviewed changes

evidolob added 2 commits February 12, 2018 16:40

#8701 add copyright header

3038bd3

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

#8701 use full Theia paclage.json from upstream

0cc4f51

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

benoitf reviewed Feb 13, 2018

View reviewed changes

#8701 add missing eof line

4a381c7

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

benoitf reviewed Feb 13, 2018

View reviewed changes

benoitf approved these changes Feb 13, 2018

View reviewed changes

#8701 remove commented ENV

3adcb0a

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

riuvshin reviewed Feb 13, 2018

View reviewed changes

#8701 change plugin list description

a69662f

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

User build-arg for GITHUB_TOKEN

412341f

riuvshin approved these changes Feb 15, 2018

View reviewed changes

Use new theia image

79d06c5

ashumilova approved these changes Feb 26, 2018

View reviewed changes

evidolob merged commit a5494dd into master Mar 5, 2018

evidolob deleted the theia-launcher branch March 5, 2018 07:48

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 5, 2018

benoitf added this to the 6.2.0 milestone Mar 5, 2018

hkolvenbach pushed a commit to hkolvenbach/che that referenced this pull request Mar 12, 2018

Theia docker file with launcher script (eclipse-che#8732)

368e418

* eclipse-che#8701 create launcher for theia Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theia docker file with launcher script #8732

Theia docker file with launcher script #8732

evidolob commented Feb 12, 2018

benoitf Feb 12, 2018

evidolob Feb 12, 2018

benoitf Feb 12, 2018

ghost Feb 12, 2018

benoitf Feb 12, 2018

benoitf Feb 12, 2018

benoitf Feb 13, 2018

evidolob Feb 13, 2018

benoitf Feb 13, 2018

evidolob Feb 13, 2018

benoitf Feb 13, 2018

riuvshin Feb 13, 2018

benoitf Feb 13, 2018

ghost Feb 13, 2018 •

edited by ghost

Loading

ghost Feb 13, 2018

l0rd Feb 13, 2018

ghost Feb 13, 2018

l0rd Feb 13, 2018

riuvshin Feb 13, 2018 •

edited

Loading

ghost Feb 13, 2018

riuvshin Feb 14, 2018

benoitf commented Feb 13, 2018 •

edited

Loading

ghost commented Feb 13, 2018

benoitf commented Feb 13, 2018

ghost commented Feb 13, 2018

evidolob commented Feb 13, 2018

benoitf commented Feb 13, 2018

evidolob commented Feb 14, 2018

ghost commented Feb 14, 2018 •

edited by ghost

Loading

l0rd commented Feb 26, 2018

Theia docker file with launcher script #8732

Theia docker file with launcher script #8732

Conversation

evidolob commented Feb 12, 2018

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost Feb 13, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riuvshin Feb 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoitf commented Feb 13, 2018 • edited Loading

ghost commented Feb 13, 2018

benoitf commented Feb 13, 2018

ghost commented Feb 13, 2018

evidolob commented Feb 13, 2018

benoitf commented Feb 13, 2018

evidolob commented Feb 14, 2018

ghost commented Feb 14, 2018 • edited by ghost Loading

l0rd commented Feb 26, 2018

ghost Feb 13, 2018 •

edited by ghost

Loading

riuvshin Feb 13, 2018 •

edited

Loading

benoitf commented Feb 13, 2018 •

edited

Loading

ghost commented Feb 14, 2018 •

edited by ghost

Loading