Improve functionality of identity provider token retrieval #8873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
skabashnyuk
and removed request for
vparfonov
sleshchenko
reviewed
Feb 22, 2018
| * | ||
| * @author Max Shaposhnik (mshaposh@redhat.com) | ||
| */ | ||
| public class KeycloakServiceClient { |
|
|
||
| private KeycloakSettings keycloakSettings; | ||
|
|
||
| private final Pattern assotiateUserPattern = |
| * | ||
| * @param oauthProvider provider name | ||
| * @return KeycloakTokenResponse token response | ||
| * @throws ForbiddenException |
| int delimiterIndex = p.indexOf("="); | ||
| queryPairs.put(p.substring(0, delimiterIndex), p.substring(delimiterIndex + 1)); | ||
| }); | ||
| return new Gson().toJson(queryPairs); |
There was a problem hiding this comment.
It think it'd better to have singleton GSON instance in static field
| @DTO | ||
| public interface KeycloakTokenResponse { | ||
|
|
||
| String getAccess_token(); |
There was a problem hiding this comment.
I think it's better to rewrite it in the following way:
@JsonFieldName("access_token")
String getAccessToken();
There was a problem hiding this comment.
ups, forgot this trick, tnx
akorneta
reviewed
Feb 22, 2018
| // If user has no link with identity provider yet, | ||
| // we should threat this as unauthorized and send to oAuth login page. | ||
| throw new UnauthorizedException(e.getMessage()); | ||
| } else { |
akorneta
reviewed
Feb 22, 2018
| && contentType != null | ||
| && !(contentType.startsWith(MediaType.APPLICATION_JSON) | ||
| || contentType.startsWith("application/vnd.api+json"))) { | ||
| throw new IOException(conn.getResponseMessage()); |
There was a problem hiding this comment.
maybe it is better to throw BadRequestException with message like 'unsupported format' or add meaningful message, wdyt?
akorneta
approved these changes
Feb 22, 2018
skabashnyuk
approved these changes
Feb 23, 2018
|
Fixed; |
benoitf
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR intoduces a dedicated HTTP client for Keycloak operations, which is more accurately covers some cases like:
What issues does this PR fix or reference?
#8288
Release Notes
Fix constant OAuth error when current user haven't identity provider link
Docs PR
N/A