Buffer input file change events and disable file tracking during git reset #8889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reset Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
added
kind/bug
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
|
ci-test |
|
ci-test build report: |
musienko-maxim
approved these changes
Mar 5, 2018
dkuleshov
approved these changes
Mar 5, 2018
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vparfonov
approved these changes
Mar 6, 2018
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4488/ |
hkolvenbach
pushed a commit
to hkolvenbach/che
that referenced
this pull request
Mar 12, 2018
…reset (eclipse-che#8889) * Buffer input file change events and disable file tracking during git reset Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Process exceptional situation and resume file watcher service Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Working copy Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Working copy Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Working copy Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Fix formatting Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Working copy Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal provides two dedicated change set.
At first, when jGit performs git reset it creates temporary files, which you can see on below screenshot:
thats why file watcher service conceives this as dedicated file changing events and firing client to update the view. As a solution there is a proposal to suspend file watcher service before performing git reset and resume it after.
At second, when client receives a batch of file changing events there is no need to process each event if some or all of them are performed in one directory, there is a handler, which consumes events and calculates common path if there is a batch of events. (For single event the logic didn't change)
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
#7773
Release Notes
N/A
Docs PR
N/A