Fix context propagation for bootstrap and server checks #8924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akorneta
added
kind/bug
akorneta
requested review from
davidfestal,
skabashnyuk,
garagatyi and
sleshchenko
davidfestal
approved these changes
Feb 27, 2018
There was a problem hiding this comment.
With the change it seems to provide the right environment context to the threads that effectively perform the workspace start.
And multi-tenant rh-che on Che6 is not broken anymore.
So approving even if I didn't catch fully how environment context propagation works.
garagatyi
reviewed
Feb 27, 2018
| serversAndProbesFuture.whenComplete((ok, ex) -> serversReadyFuture.cancel(true)); | ||
| } catch (InfrastructureException ex) { | ||
| serversAndProbesFuture.completeExceptionally(ex); | ||
| EnvironmentContext.setCurrent(context); |
There was a problem hiding this comment.
What if there would be a method that wraps anything with context setting. Would the code be simpler with less indentation (which leads to complexity of code reading)?
Example:
.thenCompose(setContext(context, bootstrap(toCancelFutures, machine)))There was a problem hiding this comment.
sure, that makes sense, I'll think about that
skabashnyuk
approved these changes
Feb 27, 2018
garagatyi
approved these changes
Feb 27, 2018
akorneta
force-pushed
the
fix-context-propagation
branch
from
9908a31
to
eefca12
Compare
akorneta
force-pushed
the
fix-context-propagation
branch
from
eefca12
to
b56001f
Compare
akorneta
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After the merge of #8836, we got a problem with start of workspaces in rh-che. The reason for these failures is there are no token in environment context while a machine is bootstrapping. The absence of the token in context causes the kubernetes client to attempt to make requests on behalf of an anonymous user.