Selenium: Add new methods to the "SeleniumWebDriverHelper" class #8995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
status/code-review
dmytro-ndp
reviewed
Mar 3, 2018
| * <p>throws {@link org.openqa.selenium.TimeoutException} if at least one of the found | ||
| * elements is not visible after timeout; | ||
| */ | ||
| public List<WebElement> waitAllVisibility(By elementsLocator, int timeout) { |
There was a problem hiding this comment.
IMHO method name waitVisibilityOfAllElements() sounds clearer.
dmytro-ndp
reviewed
Mar 3, 2018
| * @param elementsLocator common locator for multiple elements | ||
| * @return all found elements | ||
| */ | ||
| public List<WebElement> waitAllPresence(By elementsLocator) { |
There was a problem hiding this comment.
IMHO method name waitPresenceOfAllElements() sounds clearer.
dmytro-ndp
reviewed
Mar 3, 2018
| } | ||
|
|
||
| /** | ||
| * Waits until all {@link WebElement} with provided {@code elementsLocator} be attached to DOM it |
There was a problem hiding this comment.
be attached > are attached
it does not mean that elements are visible > They are not necessary have to be visible.
dmytro-ndp
approved these changes
Mar 3, 2018
SkorikSergey
approved these changes
Mar 3, 2018
Ohrimenko1988
removed
the
status/code-review
hkolvenbach
pushed a commit
to hkolvenbach/che
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new methods to the "SeleniumWebDriverHelper" class
What issues does this PR fix or reference?
Issue: #8988
Release Notes
Docs PR