Cache node modules before rebuild Theia with selected plugins. #9096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use to speed build. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
benoitf
changed the title
ghost
approved these changes
Mar 15, 2018
evidolob
approved these changes
Mar 15, 2018
benoitf
reviewed
Mar 15, 2018
dockerfiles/theia/src/main.js
Outdated
| @@ -14,7 +14,8 @@ const cp = require("child_process"); | |||
| const theiaRoot = '/home/theia'; | |||
| const theiaPath = theiaRoot + '/package.json'; | |||
|
|
|||
| const defaultConfig = require('/home/default/theia/package.json'); | |||
| const defaultTheia = `/home/default/theia`; | |||
There was a problem hiding this comment.
maybe append Path at the end of this new variable ?
benoitf
reviewed
Mar 15, 2018
dockerfiles/theia/Dockerfile
Outdated
| @@ -22,6 +22,8 @@ RUN yarn && \ | |||
| cd /home/default/theia && \ | |||
| yarn && \ | |||
| yarn theia build | |||
| RUN ln -sf /home/default/theia/node_modules /home/theia/node_modules | |||
There was a problem hiding this comment.
could you merge these two run instructions with the previous RUN instruction (adding &&)
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
benoitf
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cash node modules before rebuild Theia with selected plugins.
Should use to speed build.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com