Selenium: Rework static classes "CommandsEditorType" and "CommandsMacrosLinkType" to enumerations #9256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
kind/task
dmytro-ndp
reviewed
Mar 27, 2018
| "(" + ACTIVE_EDITOR_ENTRY_POINT + "//a[@id='gwt-debug-link-explore_macros'])[1]"; | ||
| public static final String PREVIEW_MACROS_LINK = | ||
| "(" + ACTIVE_EDITOR_ENTRY_POINT + "//a[@id='gwt-debug-link-explore_macros'])[2]"; | ||
| public enum CommandsMacrosLinkType { |
There was a problem hiding this comment.
Is it really about link to ONE macro? If so, lets fix enum and constant names to refer to ONE macro.
There was a problem hiding this comment.
I think we should leave this enum name
dmytro-ndp
reviewed
Mar 27, 2018
| "(" + Locators.ORION_ACTIVE_EDITOR_CONTAINER_XPATH + ")[1]"; | ||
| public static final String PREVIEW_URL_EDITOR = | ||
| "(" + Locators.ORION_ACTIVE_EDITOR_CONTAINER_XPATH + ")[2]"; | ||
| public enum CommandsEditorType { |
There was a problem hiding this comment.
IMHO this enum describes locators, so the name CommandsEditorLocator is more precise, as for me.
dmytro-ndp
reviewed
Mar 27, 2018
| "(" + ACTIVE_EDITOR_ENTRY_POINT + "//a[@id='gwt-debug-link-explore_macros'])[1]"; | ||
| public static final String PREVIEW_MACROS_LINK = | ||
| "(" + ACTIVE_EDITOR_ENTRY_POINT + "//a[@id='gwt-debug-link-explore_macros'])[2]"; | ||
| public enum CommandsMacrosLinkType { |
There was a problem hiding this comment.
IMHO this enum describes locators, so the name CommandsMacrosLinkLocator is more precise, as for me.
dmytro-ndp
approved these changes
Mar 27, 2018
artaleks9
approved these changes
Mar 27, 2018
Ohrimenko1988
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rework static classes "CommandsEditorType" and "CommandsMacrosLinkType" to enumerations
What issues does this PR fix or reference?
Issue: #9253
Release Notes
Docs PR