Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium: not check Workspace API installer changeability in WorkspaceDetailsSingleMachineTest test #9350

Merged
merged 2 commits into from
Apr 6, 2018

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

This PR removes checking that Workspace API installer is not changeable because for now all installer can be disabled.

selection_225

@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. team/che-qe labels Apr 6, 2018
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to hold isInstallerStateNotChangeable() method at all?

@SkorikSergey
Copy link
Contributor Author

SkorikSergey commented Apr 6, 2018

After changes of #9322 issue all installers state can be switched and this method is redundant.

@SkorikSergey SkorikSergey removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 6, 2018
@SkorikSergey SkorikSergey merged commit b312f47 into master Apr 6, 2018
@SkorikSergey SkorikSergey deleted the fixWorkspaceDetailsSingleMachineTest branch April 6, 2018 09:45
@benoitf benoitf added this to the 6.4.0 milestone Apr 6, 2018
dmytro-ndp pushed a commit that referenced this pull request Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants