Fix workspace loader which should pass its query strings to the underlying alternate IDE #9370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lying alternate IDE Signed-off-by: Sun Tan <sutan@redhat.com>
sunix
added
the
kind/bug
benoitf
added
the
status/code-review
ashumilova
approved these changes
Apr 11, 2018
benoitf
removed
the
status/code-review
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When starting a Che factory with an alternate IDE, workspace loader should pass its query string to the underlying ide url. This is done for the legacy gwt ide but not preconfigured IDE such as Theia.
This PR is fixing it.
What issues does this PR fix or reference?
#9221