Make exec agent not to use setsid for other than Linux OSes #9371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
the
status/code-review
gazarenkov
added
kind/task
|
ci-test |
|
ci-test build report: |
|
ci-test |
sleshchenko
approved these changes
Apr 11, 2018
| // wrap command to be able to kill child processes see https://github.com/golang/go/issues/8854 | ||
| cmd := exec.Command("setsid", shellInterpreter, "-c", newProcess.CommandLine) | ||
|
|
||
| var cmd *exec.Cmd |
There was a problem hiding this comment.
Looks like that formatting is wrong. Please execute
go fmt agents/go-agents/core/process/process.go
There was a problem hiding this comment.
Done, thanks for suggestion
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4507/ |
benoitf
removed
the
status/code-review
|
ci-test build report: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently exec agent uses "setsid" launching new command. It does not work OOTB for other than Linux OS since there are no setsid installed by default. This PR improve it making it possible to launch exec agent on other than Linux systems not requiring to install additional software
What issues does this PR fix or reference?
n/a
Release Notes
n/a