Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-912 returning no value instead of throwing an exception when project is not a SVN repository #944

Merged
merged 1 commit into from
Mar 31, 2016
Merged

CHE-912 returning no value instead of throwing an exception when project is not a SVN repository #944

merged 1 commit into from
Mar 31, 2016

Conversation

stour
Copy link

@stour stour commented Mar 31, 2016

CHE-912 returning no value instead of throwning an exception when pro…
1688241 
…ject is not a SVN repository

Signed-off-by: Stéphane Tournié <stephane.tournie@serli.com>
@skabashnyuk
Copy link
Contributor

why?

@stour
Copy link
Author

stour commented Mar 31, 2016

As described in issue currently you cannot import a Git project if it does not contain a '.svn' subfolder. This is a not an expected behavior, I guess you agree ?
So when the project is not a SVN project we need to return an empty list of values and not throw an exception.

It's the same logic as in plugin-git.

@skabashnyuk
Copy link
Contributor

LGTM

@vparfonov
Copy link
Contributor

ok

@stour stour merged commit 9c74fae into eclipse-che:master Mar 31, 2016
@stour stour deleted the CHE-912 branch March 31, 2016 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stour @skabashnyuk @vparfonov