Fix calculation Projects Root so it wont cause NPE if there are no 'project' volume defined #9440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/context/AppContextImpl.java
…roject' volume defined
…re no 'project' volume defined" This reverts commit 127a79e.
…roject' volume defined
gazarenkov
added
the
kind/bug
gazarenkov
requested review from
skabashnyuk,
azatsarynnyy,
vparfonov and
musienko-maxim
benoitf
added
the
status/code-review
azatsarynnyy
approved these changes
Apr 16, 2018
|
ci-test |
|
ci-test build report: |
|
ci-build |
|
Build # 4513 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4513/ to view the results. |
|
ci-build |
|
Build # 4514 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4514/ to view the results. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4515/ |
vparfonov
approved these changes
Apr 16, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix calculation Projects Root so it wont cause NPE if there are no 'project' volume defined (as it was assumed for 'dev-machine')
It checks if there are no 'project' volume - default (backward compatible) "/projects" folder applied
What issues does this PR fix or reference?
n/a
Release Notes
n/a