Selenium: adapt dashboard selenium tests for OSIO #9448

SkorikSergey · 2018-04-16T14:56:46Z

What does this PR do?

This PR adapt selenium test from dashboard package for OSIO.

What issues does this PR fix or reference?

Host to run Che 6 on OSIO: https://rhche.prod-preview.openshift.io

For example, the command to run Dashboard related tests on https://rhche.prod-preview.openshift.io from the che/selenium/che-selenium-test directory:
export CHE_INFRASTRUCTURE=openshift \
&& export CHE_TESTUSER_NAME='<username>' \
&& export CHE_TESTUSER_EMAIL='<user-email>' \
&& export CHE_TESTUSER_PASSWORD='<password>' \
&& export CHE_TESTUSER_OFFLINE__TOKEN=<offline-token> \
&& export CHE_OFFLINE_TO_ACCESS_TOKEN_EXCHANGE_ENDPOINT=https://auth.prod-preview.openshift.io/api/token/refresh \
&& ./selenium-tests.sh --test=org.eclipse.che.selenium.dashboard.** --host=rhche.prod-preview.openshift.io --https --port=443 -Dgroups=osio --multiuser --threads=1

…shboardTestsForOSIO

…mGitHubTest

…shboardTestsForOSIO

SkorikSergey · 2018-04-16T14:56:59Z

ci-test

codenvy-ci · 2018-04-16T20:43:37Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9448
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…oader page object

SkorikSergey · 2018-04-17T08:19:20Z

ci-test

codenvy-ci · 2018-04-17T13:48:35Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9448
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…shboardTestsForOSIO

dmytro-ndp · 2018-04-19T11:17:00Z

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java

@@ -155,6 +158,7 @@ public void shouldCreatingFactoryFromWorkspace() {
    createFactoryPage.clickOnSourceTab(WORKSPACE_TAB_ID);
    createFactoryPage.typeFactoryName(FACTORY_CREATED_FROM_WORKSPACE_NAME);
    createFactoryPage.clickOnWorkspaceFromList(WORKSPACE_NAME);
+    WaitUtils.sleepQuietly(1);


Please, comment why we need sleep here.

dmytro-ndp · 2018-04-19T11:23:58Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ToastLoader.java

+
+  public void waitToastLoaderAndClickButton(String buttonName) {
+    projectExplorer.waitProjectExplorer();
+    WaitUtils.sleepQuietly(5);


It's better to use helper method SeleniumWebDriverHelper#waitInvisibility(WebElement webElement, int timeout) and handle TimeoutException by calling clickOnToastLoaderButton(buttonName) method to shorten 5 seconds timeout.
It also requires clear documentation on this method.

dmytro-ndp · 2018-04-19T11:26:12Z

...enium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateAndDeleteProjectsTest.java

@@ -85,6 +90,7 @@ public void createAndDeleteProjectTest() throws ExecutionException, InterruptedE
    newWorkspace.clickOnCreateButtonAndOpenInIDE();

    String dashboardWindow = seleniumWebDriverHelper.switchToIdeFrameAndWaitAvailability();
+    toastLoader.waitToastLoaderAndClickButton("Start");


IMHO we can involve separate method waitToastLoaderAndClickStartButton() to leave list of arguments an empty.

dmytro-ndp · 2018-04-19T11:27:03Z

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java

@@ -196,9 +200,9 @@ private void createWorkspaceWithProject(String workspaceName) {
    workspaces.clickOnAddWorkspaceBtn();
    newWorkspace.waitToolbar();
    loader.waitOnClosed();
+    newWorkspace.clickOnAllStacksTab();


please, comment on why we can't rely on Quick Start stack list.

The Java stack, which we use for creating test workspaces, not exist in Quick Start stacks list on OSIO.

dmytro-ndp · 2018-04-19T11:27:47Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ToastLoader.java

@@ -67,6 +70,10 @@ public void waitToastLoaderIsOpen() {
    seleniumWebDriverHelper.waitVisibility(mainForm, UPDATING_PROJECT_TIMEOUT_SEC);
  }

+  public Boolean isToastLoaderIsOpened() {


correct name is isToastLoaderOpened

dmytro-ndp · 2018-04-19T11:28:21Z

...enium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateAndDeleteProjectsTest.java

@@ -76,6 +80,7 @@ public void createAndDeleteProjectTest() throws ExecutionException, InterruptedE
    workspaces.clickOnAddWorkspaceBtn();
    newWorkspace.waitToolbar();

+    newWorkspace.clickOnAllStacksTab();


please, leave comment about why we can't rely on Quick Start stack list.

The Java stack, which we use for creating test workspaces, not exist in Quick Start stacks list on OSIO.

dmytro-ndp · 2018-04-19T11:29:13Z

.../che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateWorkspaceTest.java

@@ -133,13 +133,13 @@ public void checkFiltersStacksFeature() {
    newWorkspace.clickOnMultiMachineTab();
    assertFalse(newWorkspace.isStackVisible(JAVA.getId()));

-    // filter stacks by 'php' value and check filtered stacks list
+    // filter stacks by 'blank' value and check filtered stacks list


please, leave comment about why we need to user blank stack name

We used here Blank stack because PHP stack not exist on OSIO.

dmytro-ndp · 2018-04-19T11:29:44Z

...ium-test/src/test/java/org/eclipse/che/selenium/dashboard/ImportMavenProjectFromGitTest.java

@@ -61,6 +66,7 @@ public void checkAbilityImportMavenProjectTest() throws ExecutionException, Inte

    workspaces.clickOnAddWorkspaceBtn();
    newWorkspace.waitToolbar();
+    newWorkspace.clickOnAllStacksTab();


please, leave comment about why we can't rely on Quick Start stack list.

The Java stack, which we use for creating test workspaces, not exist in Quick Start stacks list on OSIO.

dmytro-ndp · 2018-04-19T11:29:57Z

...enium-test/src/test/java/org/eclipse/che/selenium/dashboard/ImportProjectFromGitHubTest.java

@@ -81,6 +85,7 @@ public void checkAbilityImportProjectFromGithub() throws Exception {
    dashboard.selectWorkspacesItemOnDashboard();
    workspaces.clickOnAddWorkspaceBtn();
    newWorkspace.waitToolbar();
+    newWorkspace.clickOnAllStacksTab();


please, leave comment about why we can't rely on Quick Start stack list.

The Java stack, which we use for creating test workspaces, not exist in Quick Start stacks list on OSIO.

dmytro-ndp · 2018-04-19T11:30:05Z

...selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/ImportProjectFromZipTest.java

@@ -61,6 +66,7 @@ public void importProjectFromZipTest() throws ExecutionException, InterruptedExc

    workspaces.clickOnAddWorkspaceBtn();
    newWorkspace.waitToolbar();
+    newWorkspace.clickOnAllStacksTab();


please, leave comment about why we can't rely on Quick Start stack list.

The Java stack, which we use for creating test workspaces, not exist in Quick Start stacks list on OSIO.

dmytro-ndp · 2018-04-19T11:30:20Z

...m/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/WorkspacesListTest.java

@@ -215,6 +216,7 @@ private void createWorkspace(String name) {

    workspaces.clickOnAddWorkspaceBtn();
    newWorkspace.waitToolbar();
+    newWorkspace.clickOnAllStacksTab();


please, leave comment about why we can't rely on Quick Start stack list.

The Java stack, which we use for creating test workspaces, not exist in Quick Start stacks list on OSIO.

…ed comments

SkorikSergey · 2018-04-19T15:03:22Z

ci-test

codenvy-ci · 2018-04-19T20:44:03Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9448
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-04-23T09:02:10Z

Could you, please, leave command to start OSIO specific tests in description to this PR?

…shboardTestsForOSIO

SkorikSergey added 6 commits April 13, 2018 14:41

Dashboard tests changed to start on OSIO

f7fed34

click on Start button in ToastLoader after workspace starting

1f7f703

Merge branch 'master' of https://github.com/eclipse/che into reworkDa…

f3a44cc

…shboardTestsForOSIO

checking for Toast Loader 'Start' button moved to IDE page object

01d6034

added try/catch block with info about known issue in ImportProjectFro…

673ff81

…mGitHubTest

Merge branch 'master' of https://github.com/eclipse/che into reworkDa…

e749299

…shboardTestsForOSIO

SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Apr 16, 2018

SkorikSergey requested a review from vparfonov as a code owner April 16, 2018 14:56

SkorikSergey added 2 commits April 17, 2018 09:59

check that Toast Loader is visible after workspace starting in ToastL…

3cd3704

…oader page object

merged from master

732776e

SkorikSergey added 4 commits April 18, 2018 15:04

Merge branch 'master' of https://github.com/eclipse/che into reworkDa…

28dda1a

…shboardTestsForOSIO

Merge branch 'master' of https://github.com/eclipse/che into reworkDa…

26a2433

…shboardTestsForOSIO

added 'osio' group to dashboard tests

2e09840

Merge branch 'master' of https://github.com/eclipse/che into reworkDa…

4398660

…shboardTestsForOSIO

dmytro-ndp reviewed Apr 19, 2018

View reviewed changes

SkorikSergey requested a review from dmytro-ndp April 19, 2018 11:24

dmytro-ndp reviewed Apr 19, 2018

View reviewed changes

changed method for checking ToastLoader after workspace starting, add…

59cfba3

…ed comments

SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 19, 2018

SkorikSergey added 2 commits April 23, 2018 12:05

added comments

9c7e943

Merge branch 'master' of https://github.com/eclipse/che into reworkDa…

8c34808

…shboardTestsForOSIO

dmytro-ndp approved these changes Apr 23, 2018

View reviewed changes

SkorikSergey merged commit 781dc58 into master Apr 23, 2018

SkorikSergey deleted the reworkDashboardTestsForOSIO branch April 23, 2018 10:58

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 23, 2018

benoitf added this to the 6.5.0 milestone Apr 23, 2018

SkorikSergey mentioned this pull request Apr 25, 2018

Execute selenium tests from dashboard package on OSIO #9539

Closed

hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018

Selenium: adapt dashboard selenium tests for OSIO (eclipse-che#9448)

7e18f94

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selenium: adapt dashboard selenium tests for OSIO #9448

Selenium: adapt dashboard selenium tests for OSIO #9448

SkorikSergey commented Apr 16, 2018 •

edited

Loading

SkorikSergey commented Apr 16, 2018

codenvy-ci commented Apr 16, 2018

SkorikSergey commented Apr 17, 2018

codenvy-ci commented Apr 17, 2018

dmytro-ndp Apr 19, 2018

dmytro-ndp Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018

SkorikSergey Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018

dmytro-ndp Apr 19, 2018

SkorikSergey Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018

SkorikSergey Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018

SkorikSergey Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018

SkorikSergey Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018

SkorikSergey Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018

SkorikSergey Apr 19, 2018 •

edited

Loading

SkorikSergey commented Apr 19, 2018

codenvy-ci commented Apr 19, 2018

dmytro-ndp commented Apr 23, 2018

Selenium: adapt dashboard selenium tests for OSIO #9448

Selenium: adapt dashboard selenium tests for OSIO #9448

Conversation

SkorikSergey commented Apr 16, 2018 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

SkorikSergey commented Apr 16, 2018

codenvy-ci commented Apr 16, 2018

SkorikSergey commented Apr 17, 2018

codenvy-ci commented Apr 17, 2018

Choose a reason for hiding this comment

dmytro-ndp Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

dmytro-ndp Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

SkorikSergey commented Apr 19, 2018

codenvy-ci commented Apr 19, 2018

dmytro-ndp commented Apr 23, 2018

SkorikSergey commented Apr 16, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018 •

edited

Loading

dmytro-ndp Apr 19, 2018 •

edited

Loading

SkorikSergey Apr 19, 2018 •

edited

Loading

SkorikSergey Apr 19, 2018 •

edited

Loading

SkorikSergey Apr 19, 2018 •

edited

Loading

SkorikSergey Apr 19, 2018 •

edited

Loading

SkorikSergey Apr 19, 2018 •

edited

Loading

SkorikSergey Apr 19, 2018 •

edited

Loading

SkorikSergey Apr 19, 2018 •

edited

Loading