Make Keycloak Admin configurable #9490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
benoitf,
garagatyi,
l0rd and
riuvshin
as code owners
benoitf
added
status/code-review
riuvshin
reviewed
Apr 19, 2018
| @@ -24,6 +21,12 @@ cat /scripts/che-realm.json.erb | \ | |||
| sed -e "s@<%= scope\.lookupvar('che::che_server_url') %>@${PROTOCOL}://che-${NAMESPACE}.${ROUTING_SUFFIX}@" \ | |||
| > /scripts/che-realm.json | |||
|
|
|||
| echo "Creating Admin user..." | |||
|
|
|||
| if [ $KEYCLOAK_USER ] && [ $KEYCLOAK_PASSWORD ]; then | |||
There was a problem hiding this comment.
Basically reused this https://github.com/jboss-dockerfiles/keycloak/blob/3.3.0.CR2-3/server/docker-entrypoint.sh
In fact, even a check isn't really required since ENVS are set in deploymentConfig.
garagatyi
approved these changes
Apr 19, 2018
| displayName: Keycloak admin password | ||
| description: Default Keycloak admin password. Can be changed after login | ||
| value: "admin" | ||
| value: http |
| @@ -140,10 +140,20 @@ objects: | |||
| storage: 1Gi | |||
|
|
|||
| parameters: | |||
|
|
|||
riuvshin
approved these changes
Apr 19, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
* Make Keycloak Admin configurable * Make Keycloak Admin configurable * Fix typos
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes Keycloak admin user name and password configurable
What issues does this PR fix or reference?
#9489