Update deploy_che script #9513
Merged
Update deploy_che script #9513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ashumilova,
benoitf,
garagatyi,
l0rd and
riuvshin
as code owners
benoitf
added
the
status/code-review
sleshchenko
reviewed
Apr 25, 2018
deploy/openshift/deploy_che.sh
Outdated
| ENV vars: this script automatically detect envs vars beginning with "CHE_" and passes them to Che deployments: | ||
| CHE_IMAGE_REPO - Che server Docker image, defaults to "eclipse-che-server" | ||
| CHE_IMAGE_TAG - Set che-server image tag, defaults to "nightly" | ||
| CHE_INFRA_KUBERNETES_PROJECT - namespace for workspace objects (defaults to eclipse-che). A separate ws namespace can be used only if username/password or token is provided |
There was a problem hiding this comment.
CHE_INFRA_KUBERNETES_NAMESPACE is used for Kubernetes Infra.
CHE_INFRA_OPENSHIFT_PROJECT is used for OpenShift Infra.
deploy/openshift/deploy_che.sh
Outdated
| ${ENV} | ||
|
|
||
| if [ ${UPDATE_STRATEGY} == "Recreate" ]; then | ||
| ${OC_BINARY} apply -f ${BASE_DIR}/templates/pvc/che-server-pvc.yaml |
There was a problem hiding this comment.
Looks like the formatting is broken here. Please check
deploy/openshift/ocp.sh
Outdated
| --rolling - rolling update strategy (Recreate is the default one) | ||
| --wait-che - track Che deployment progress until pod is healthy | ||
| --debug - deploy Che in a debug mode, create and expose debug route | ||
| --image-che= - override default Che image. Example --image-che=org/repo:tag. Tag is mandatory! |
There was a problem hiding this comment.
looks like = symbol is redundant
There was a problem hiding this comment.
Yes, makes sense - the format is in the example anyway
added 2 commits
April 25, 2018 10:18
ghost
changed the title
benoitf
added
the
kind/enhancement
sleshchenko
approved these changes
Apr 30, 2018
deploy/openshift/deploy_che.sh
Outdated
| ENV vars: this script automatically detect envs vars beginning with "CHE_" and passes them to Che deployments: | ||
| CHE_IMAGE_REPO - Che server Docker image, defaults to "eclipse-che-server" | ||
| CHE_IMAGE_TAG - Set che-server image tag, defaults to "nightly" | ||
| CHE_INFRA_OPENSHIFT_PROJECT - namespace for workspace objects (defaults to eclipse-che). A separate ws namespace can be used only if username/password or token is provided |
There was a problem hiding this comment.
I'd say that default value is not eclipse-che but the same as CHE_OPENSHIFT_PROJECT or specified with --p parameter
deploy/openshift/deploy_che.sh
Outdated
| printInfo "Che successfully deployed and will be soon available at ${HTTP_PROTOCOL}://${CHE_ROUTE}" | ||
| exposeDebugService | ||
| if [ "${WAIT_FOR_CHE}" == "true" ]; then | ||
| wait_for_che |
deploy/openshift/ocp.sh
Outdated
| --rolling - rolling update strategy (Recreate is the default one) | ||
| --wait-che - track Che deployment progress until pod is healthy | ||
| --debug - deploy Che in a debug mode, create and expose debug route | ||
| --image-che - override default Che image. Example --image-che=org/repo:tag. Tag is mandatory! |
There was a problem hiding this comment.
looks like information about -p, --project parameter is missing.
deploy/openshift/deploy_che.sh
Outdated
| # -------------------------------------------------------- | ||
| HELP=" | ||
| --help - script help menu | ||
| --project | -p - OpenShift namespace to deploy Che (defaults to eclipse-che) |
There was a problem hiding this comment.
Please add example the same as for --image-che, because it is not clear that value should be separated with =
riuvshin
approved these changes
May 4, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
* Update OpenShift Origin version to 3.9 * Deploy script uses templates * Pass args to deploy script * Remove old scripts and yamls * Add missing args to ocp.sh help and and help to deploy_che.sh * Small fixes * Remove mistakenly added file * Remove mistakenly added file * Remove -a in docker ps to get registry container * Do not pass args but export envs in ocp.sh * Messed envs a bit * Delete test service that is used to compute routing suffix * Remove unnecessary port from Keycloak route * Fixes * Fixes * Typo * Minor fixes
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After #9190 has been merged, existing deploy_che.sh and everything not in
deploy/openshift/templatesdirectory should go away (helper scripts and yamls) and start using new templates (deploy_che.sh).This PR:
ocp.shanddeploy_che.share left. Both have help menus and are quite clear to follow the deployment logicdeploy_che.shtemplates friendly, i.e. deployment happens by applying templates.deploy_che.shso that once can override most commonly used ENVS and params like update strategy, pull policy, deployment image, https support, multi user flavor, etc.deploy_che.shto grab all local env variables beginning withCHE_and pass them to Che deployment. Envs and params are printed before templates are applied.ROUTING_SUFFIXis exported (for example,ocp.shdoes that), it is used as is.deploy_che.sh. The script deploys Che with a set of envs and params to any OpenShift cluster be it MiniShift, a local Origin, OSD, OCP or OSO. There's just one pre-req: one needs to be logged in oc, i.e. have an active session (oc whoamiis the test command in the script). So, when deploying, say, to OSO or OCP/OSD, all one needs to do is to login to cluster usingocand run./deploy_che.shwith a set of commands. It is possible that the desired namespace name already exists (in someone else's account) - it is possible to provide own with-p | --projectparameter.Tested with Origin (oc cluster up locally) and OSO Pro.