Remove Keycloak job, use the right entrypoint, add envs the script re… #9533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
garagatyi,
l0rd,
riuvshin and
sleshchenko
as code owners
benoitf
added
status/code-review
guydc
reviewed
Apr 25, 2018
| @@ -45,7 +45,19 @@ spec: | |||
| value: admin | |||
| - name: CHE_HOST | |||
| value: {{ template "cheHost" . }} | |||
| - name: ROUTING_SUFFIX | |||
There was a problem hiding this comment.
Is it possible to use the Che HostHelper template instead of passing the ingress domain, namespace, and constructing the hostname in the configuration script?
This will be more consistent with the way we configure ingresses, config maps, etc.
There was a problem hiding this comment.
Yes, i have thought about it, but I will then need to change the entrypoint script that expects PROTOCOL and ROUTING_SUFFIX envs.
garagatyi
approved these changes
Apr 25, 2018
sleshchenko
approved these changes
Apr 25, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
#9429