Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct process situation when project has been renamed #9582

Merged
merged 4 commits into from
May 15, 2018
Merged

Correct process situation when project has been renamed #9582

merged 4 commits into from
May 15, 2018

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented May 2, 2018

What does this PR do?

This changes proposal adds small fixes which prevents unnormal workflow of project rename. Especially for java-based projects, where after rename operation old project might not be deleted.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

#9393

Release Notes

N/A

Docs PR

N/A

@vzhukovs
Correct process situation when project has been renamed
72cd396 
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. team/ide severity/P2 Has a minor but important impact to the usage or development of the system. labels May 2, 2018
@vzhukovs vzhukovs added this to the 6.5.0 milestone May 2, 2018
@vzhukovs vzhukovs self-assigned this May 2, 2018
@vzhukovs vzhukovs requested a review from evidolob as a code owner May 2, 2018 12:04
@vzhukovs
Copy link
Contributor Author

vzhukovs commented May 2, 2018

ci-test

@vzhukovs
Copy link
Contributor Author

vzhukovs commented May 2, 2018

To be more objective, selenium tests have to be run few times to be sure that bug is not reproducible.

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 2, 2018
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9582
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vzhukovs
Formatting issue
2d627b5 
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs
Copy link
Contributor Author

vzhukovs commented May 2, 2018

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9582
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Contributor

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9582
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Contributor

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9582
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vzhukovs
Minor fixes
061df60 
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs
Merge branch 'master' into che#9393
db8c142
@vzhukovs vzhukovs removed this from the 6.5.0 milestone May 14, 2018
@vzhukovs
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9582
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim
Copy link
Contributor

The existed selenium tests did not find new regression. All 'Flaky' tests have been rerun and passed as well

@vzhukovs vzhukovs merged commit 89b9cf6 into master May 15, 2018
@vzhukovs vzhukovs deleted the che#9393 branch May 15, 2018 11:08
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 15, 2018
@benoitf benoitf added this to the 6.6.0 milestone May 15, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
@vzhukovs
Correct process situation when project has been renamed (eclipse-che#…
8f333c2 
…9582)

* Correct process situation when project has been renamed

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

* Formatting issue

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

* Minor fixes

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evidolob evidolob evidolob approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@vparfonov vparfonov vparfonov approved these changes

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@dkuleshov dkuleshov Awaiting requested review from dkuleshov

Assignees

@vzhukovs vzhukovs

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
8 participants
@vzhukovs @codenvy-ci @Ohrimenko1988 @musienko-maxim @evidolob @azatsarynnyy @vparfonov @benoitf