Build any Theia extensions which are downloaded from a git provider #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
benoitf
added
the
status/code-review
evidolob
approved these changes
May 3, 2018
benoitf
reviewed
May 3, 2018
dockerfiles/theia/src/main.js
Outdated
| @@ -123,7 +123,7 @@ function getExtraTheiaPlugins() { | |||
|
|
|||
| /** | |||
| * Clones git repository and adds the plugin as local. | |||
| * This is done becouse Theia requires npm package.json (not lerna) which is located, in most cases, in subdirectory of repository. | |||
| * This is done becouse Theia requires npm package.json (not lerna) which is located, in some cases, in subdirectory of repository. | |||
There was a problem hiding this comment.
there is a typo on "because/becouse"
benoitf
approved these changes
May 3, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes build of all Theia plugins which are downloaded form a git provider
Fixes typos