Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move building of postgresql-tck module to integration build profile #9737

Merged
merged 2 commits into from
May 22, 2018

Conversation

mkuznyetsov
Copy link
Contributor

What does this PR do?

Build 'postgresql-tck' module only as part of integration build profile, excluding it from default build cycle.

What issues does this PR fix or reference?

#9462

Release Notes

Docs PR

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 18, 2018
<module>cascade-removal</module>
</modules>
<profiles>
<profile>
<id>integration</id>
Copy link
Member

@sleshchenko sleshchenko May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now you can remove integration profile in postgresql-tck module https://github.com/eclipse/che/blob/master/wsmaster/integration-tests/postgresql-tck/pom.xml#L244. WDYT?

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuznyetsov mkuznyetsov merged commit e30d8cd into master May 22, 2018
@mkuznyetsov mkuznyetsov deleted the che-9462 branch May 22, 2018 06:46
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 22, 2018
@benoitf benoitf added this to the 6.6.0 milestone May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants