Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If node is already visible in project tree, then select it instead of reload #9747

Merged
merged 1 commit into from
May 21, 2018

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented May 18, 2018

What does this PR do?

This changes proposal adds additional check for that situation, when node has already expanded, link with editor button doesn't reload node.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

#7151 #9699

Release Notes

N/A

Docs PR

N/A

… reload

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs self-assigned this May 18, 2018
@vzhukovs vzhukovs requested a review from vparfonov as a code owner May 18, 2018 15:32
@vzhukovs vzhukovs added the status/in-progress This issue has been taken by an engineer and is under active development. label May 18, 2018
@vzhukovs
Copy link
Contributor Author

ci-test

@benoitf benoitf added the kind/bug Outline of a bug - must adhere to the bug report template. label May 18, 2018
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9747
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vzhukovs vzhukovs changed the title [WIP] If node is already visible in project tree, then select it instead of reload If node is already visible in project tree, then select it instead of reload May 21, 2018
@vzhukovs vzhukovs added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels May 21, 2018
@vzhukovs vzhukovs added this to the 6.6.0 milestone May 21, 2018
@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/257/) doesn't show any regression against this Pull request.

@vzhukovs vzhukovs merged commit 734c901 into master May 21, 2018
@vzhukovs vzhukovs deleted the che#7151 branch May 21, 2018 13:13
@vzhukovs vzhukovs removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants