-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Golang Support in Che #9803
Conversation
<artifactId>che-plugin-golang-lang-shared</artifactId> | ||
<classifier>sources</classifier> | ||
</dependency> | ||
<!--<dependency>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused code.
/** | ||
* Provides information for registering Golang project type into project wizard. | ||
* | ||
* @author Dmitry Shnurenko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CopyPaste?
ci-build |
Build # 4540 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4540/ to view the results. |
ci-test |
ci-test build report: |
Build # 4543 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4543/ to view the results. |
ci-build |
Build # 4544 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4544/ to view the results. |
ci-build |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4547/ |
ci-test |
ci-test build report: |
Good day! Are these improvements by any chance already live on codenvy.io? The default stack called "Default Go Stack with Go 1.6.2" appears to already have the latest language server setup as described in this PR, however the rich Assistant features are not visible on the IDE UI. |
@HouzuoGuo hello, no codenvy.io running 5.x version of CHE. however, it might be available on che.openshift.io |
Many thanks @riuvshin , looking forward to try this one out. |
Woah, that works incredibly well as an (almost) fully functional Go IDE :D Many thanks for your hard work! |
What does this PR do?
Brings Golang support to Che
Language Server
https://github.com/theia-ide/go-language-server
A short demo:
Restrictions
Go should be installed in the env. It makes no sense to install it in the installer script since there's no way to set GOPATH env.
In eclipse/ubuntu_go image GOPATH is set to
/projects/.che
so that it is possible to open files when looking for definitions in other packages. If GOPATH is outside/projects
it won't be possible to open files from external packages.Project type
Nothing fancy here. Basically a copy of any project type that is not Java.
Start time
If GOPATH is persisted in a volume, only the initial workspace start takes much time (~2 min depending on the network conditions).
Known issues
There are some known issues that don't seem to have a dramatic impact on the way LS works:
#9784
#9796
#9781