Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Golang Support in Che #9803

Merged
2 commits merged into from
Jun 5, 2018
Merged

WIP: Add Golang Support in Che #9803

2 commits merged into from
Jun 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2018

What does this PR do?

Brings Golang support to Che

Language Server

https://github.com/theia-ide/go-language-server

A short demo:

golang

Restrictions

  • Go should be installed in the env. It makes no sense to install it in the installer script since there's no way to set GOPATH env.

  • In eclipse/ubuntu_go image GOPATH is set to /projects/.che so that it is possible to open files when looking for definitions in other packages. If GOPATH is outside /projects it won't be possible to open files from external packages.

Project type

Nothing fancy here. Basically a copy of any project type that is not Java.

Start time

If GOPATH is persisted in a volume, only the initial workspace start takes much time (~2 min depending on the network conditions).

Known issues

There are some known issues that don't seem to have a dramatic impact on the way LS works:

#9784
#9796
#9781

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 24, 2018
<artifactId>che-plugin-golang-lang-shared</artifactId>
<classifier>sources</classifier>
</dependency>
<!--<dependency>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused code.

/**
* Provides information for registering Golang project type into project wizard.
*
* @author Dmitry Shnurenko
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CopyPaste?

@ghost
Copy link
Author

ghost commented May 27, 2018

ci-build

@codenvy-ci
Copy link

Build # 4540 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4540/ to view the results.

@ghost
Copy link
Author

ghost commented May 31, 2018

ci-test

@ghost ghost deleted a comment from codenvy-ci May 31, 2018
@ghost ghost deleted a comment from codenvy-ci May 31, 2018
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9803
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@codenvy-ci
Copy link

Build # 4543 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4543/ to view the results.

@ghost
Copy link
Author

ghost commented Jun 1, 2018

ci-build

@codenvy-ci
Copy link

Build # 4544 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4544/ to view the results.

@ghost
Copy link
Author

ghost commented Jun 4, 2018

ci-build

@codenvy-ci
Copy link

@ghost
Copy link
Author

ghost commented Jun 4, 2018

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9803
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ghost ghost merged commit 7128227 into master Jun 5, 2018
@ghost ghost deleted the golang_support branch June 5, 2018 09:48
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 5, 2018
@benoitf benoitf added this to the 6.7.0 milestone Jun 5, 2018
@vkuznyetsov vkuznyetsov mentioned this pull request Jun 6, 2018
33 tasks
@tsmaeder tsmaeder mentioned this pull request Jun 8, 2018
18 tasks
@HouzuoGuo
Copy link

Good day! Are these improvements by any chance already live on codenvy.io?

The default stack called "Default Go Stack with Go 1.6.2" appears to already have the latest language server setup as described in this PR, however the rich Assistant features are not visible on the IDE UI.

@riuvshin
Copy link
Contributor

riuvshin commented Jul 19, 2018

@HouzuoGuo hello, no codenvy.io running 5.x version of CHE. however, it might be available on che.openshift.io

@HouzuoGuo
Copy link

Many thanks @riuvshin , looking forward to try this one out.

@HouzuoGuo
Copy link

Woah, that works incredibly well as an (almost) fully functional Go IDE :D Many thanks for your hard work!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants