Improved Mass Spectra performance #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eselmeister
reviewed
Aug 18, 2022
...er.nist/src/org/eclipse/chemclipse/msd/identifier/supplier/nist/core/support/Identifier.java
Show resolved
Hide resolved
Mailaender
force-pushed
the
empty-mass-spectra
branch
from
8437990
to
25e2ae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is https://rules.sonarsource.com/java/RSPEC-1155 hidden behind custom interfaces that just seems to wrap a
List. In the case ofIMassSpectra, I assume it will be bad, as those databases can contain many entries. It should be even worse forIIonProviderbecause scans take up most of the RAM usage and item count when profiling OpenChrom.