Migrate to the Eclipse translation service #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
translation-service
branch
from
7e4f6c7
to
460701e
Compare
Mailaender
force-pushed
the
translation-service
branch
from
460701e
to
549682b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revises #1259 to use the Eclipse translation service instead of our own to reduce boiler plate code and to harmonize language settings with other parts of the UI. It has softer back falls if you feed it with untranslated strings. The downside is that you need to know both the
%TranslationIDand the contributor URI. However, the latter makes translating of JSON annotations possible, so I consider it a good thing. Note: this is just a proof of concept with all kinds of cases. There are still ~500 strings using the old system.