Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Molecule Image Service #1290

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Conversation

Mailaender
Copy link
Contributor

This fixes a collection of issues arising for having more than one image service since #1286 and #1288.

@eselmeister
Copy link
Contributor

This change looks good, but it leads to an error in the OpenChrom/CDK package:
net.openchrom.xxd.identifier.supplier.cdk.ui.services

Description	Resource	Path	Location	Type
The type MoleculeImageService must implement the inherited abstract method IMoleculeImageService.isOnline()	MoleculeImageService.java	/net.openchrom.xxd.identifier.supplier.cdk.ui/src/net/openchrom/xxd/identifier/supplier/cdk/ui/services	line 36	Java Problem

Please create a PR in the OpenChrom/CDK package, so that both PRs can be merged in sync. Additionally, a public abstract class could be added, which defines "isOnline" by default as false. Any implementation, that uses online services, shall override to true.

public abstract class AbstractMoleculeImageService implements IMoleculeImageService

@Mailaender
Copy link
Contributor Author

I can push to @OpenChrom without your help, so this shouldn't be necessary. Creating an AbstractMoleculeImageService only to default it to something that may be wrong and has to be overwritten sounds like bad design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants